Skip to content

chore(runway): cherry-pick fix: double press interaction on android#18896

Merged
sethkfman merged 2 commits into
release/7.54.0from
cherry-pick-7-54-0-045377b
Aug 28, 2025
Merged

chore(runway): cherry-pick fix: double press interaction on android#18896
sethkfman merged 2 commits into
release/7.54.0from
cherry-pick-7-54-0-045377b

Conversation

@runway-github

@runway-github runway-github Bot commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Description

  • This PR removes the double onPress interaction on Android (Tap +
    onPress both being triggered)

Changelog

CHANGELOG entry:

Related issues

Fixes: #18704

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 045377b

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

- This PR removes the double onPress interaction on Android (Tap +
onPress both being triggered)
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

Fixes: #18704

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github Bot requested a review from a team as a code owner August 28, 2025 19:04
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Aug 28, 2025
cursor[bot]

This comment was marked as outdated.

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Aug 28, 2025
@github-actions

github-actions Bot commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e438dec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d8c05d3-ae0f-4e20-bbac-5485047aeaaa

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
30.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sethkfman sethkfman added No E2E Smoke Needed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed Run Smoke E2E labels Aug 28, 2025
@sethkfman sethkfman merged commit 8bd394d into release/7.54.0 Aug 28, 2025
76 of 81 checks passed
@sethkfman sethkfman deleted the cherry-pick-7-54-0-045377b branch August 28, 2025 22:58
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 28, 2025
@metamaskbot metamaskbot added the release-7.54.0 Issue or pull request that will be included in release 7.54.0 label Sep 3, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.54.0 on PR, as PR was cherry-picked in branch 7.54.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 size-L skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

3 participants