Skip to content

chore(runway): cherry-pick fix: Updated ButtonBase and ListItems to have gesture detection on Android cp-7.53.0#18392

Merged
sethkfman merged 2 commits into
release/7.53.0from
runway-cherry-pick-7.53.0-1755274265
Aug 19, 2025
Merged

chore(runway): cherry-pick fix: Updated ButtonBase and ListItems to have gesture detection on Android cp-7.53.0#18392
sethkfman merged 2 commits into
release/7.53.0from
runway-cherry-pick-7.53.0-1755274265

Conversation

@runway-github

@runway-github runway-github Bot commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Description

This PR updated the ButtonBase, ListItemSelect, and
ListItemMultiSelect to include Gesture Detector, resolving a current
bug in react-native's TouchableOpacity component occasionally not
triggering onPress on Android

Changelog

CHANGELOG entry:

Related issues

Fixes: #18147

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Everything still functional

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-08-07.at.13.30.01.mp4
Video.Clip.2025-08-07.16_39_40.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 578bf72

…ave gesture detection on Android cp-7.53.0 (#18104)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This PR updated the `ButtonBase`, `ListItemSelect`, and
`ListItemMultiSelect` to include Gesture Detector, resolving a current
bug in `react-native`'s `TouchableOpacity` component occasionally not
triggering `onPress` on Android
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: #18147

## **Manual testing steps**

```gherkin
Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**
Everything still functional 

https://github.com/user-attachments/assets/f4e9f41e-34f7-4bf8-a090-860bee411050

https://github.com/user-attachments/assets/f2791eb2-9520-4ce7-ad3e-6d0933d59c35

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github Bot requested a review from a team as a code owner August 15, 2025 16:11
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Aug 15, 2025
@sethkfman sethkfman added Run Smoke E2E skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Aug 19, 2025
@github-actions

github-actions Bot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 37b59d4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/446af410-800a-45a0-be15-9c3f11ce2898

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianacnguyen brianacnguyen enabled auto-merge (squash) August 19, 2025 22:24
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
34.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sethkfman sethkfman disabled auto-merge August 19, 2025 22:50
@sethkfman sethkfman merged commit 5ac8b5e into release/7.53.0 Aug 19, 2025
54 of 68 checks passed
@sethkfman sethkfman deleted the runway-cherry-pick-7.53.0-1755274265 branch August 19, 2025 22:50
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 19, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Sep 3, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.53.0 on PR, as PR was cherry-picked in branch 7.53.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.53.0 Issue or pull request that will be included in release 7.53.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants