Skip to content

feat(deposit): cp-7.53.0 show recipient address in bank details screen#18051

Merged
AxelGes merged 2 commits into
mainfrom
feat/deposit/add-recipient
Aug 6, 2025
Merged

feat(deposit): cp-7.53.0 show recipient address in bank details screen#18051
AxelGes merged 2 commits into
mainfrom
feat/deposit/add-recipient

Conversation

@AxelGes

@AxelGes AxelGes commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Description

Show the address line in the bank details screen for SEPA and Wire

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Aug 6, 2025
@AxelGes AxelGes changed the title feat(deposit): show recipient address feat(deposit): cp-7.53.0 show recipient address in bank details screen Aug 6, 2025
@AxelGes AxelGes marked this pull request as ready for review August 6, 2025 20:15
@AxelGes AxelGes requested a review from a team as a code owner August 6, 2025 20:15
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7920090
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65cd0b49-eceb-4ed9-979a-1ceebd574d22

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@AxelGes AxelGes added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 6, 2025
@AxelGes AxelGes added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit dc8f82d Aug 6, 2025
59 of 64 checks passed
@AxelGes AxelGes deleted the feat/deposit/add-recipient branch August 6, 2025 21:53
@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Hi @AxelGes,

on the day following feat or perf PR merge, PM and author to test changes on main (feature + exploratory around the edges) using the latest nightly build with casual user persona and also a power user persona where performance might be a challenge. Please record the testing in a video, check the relevant post-merge checklist box below, and post the video in a comment at the bottom of this PR.

Author validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

PM validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@github-actions github-actions Bot added the needs-validation Post merge validation label Aug 6, 2025
@metamaskbot metamaskbot added the release-7.54.0 Issue or pull request that will be included in release 7.54.0 label Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wachunei wachunei wachunei approved these changes

Assignees

No one assigned

Labels

needs-validation Post merge validation No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AxelGes @wachunei @metamaskbot