Skip to content

feat: selectors for the contextual network selector#18042

Merged
Cal-L merged 3 commits into
mainfrom
feat-4173-send-flow-contextual-network-related-selectors
Aug 6, 2025
Merged

feat: selectors for the contextual network selector#18042
Cal-L merged 3 commits into
mainfrom
feat-4173-send-flow-contextual-network-related-selectors

Conversation

@vinnyhoward

@vinnyhoward vinnyhoward commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Description

This is a part of a series of pull requests based off of this parent PR Send Flow with Contextual Chain Id

This PR introduces new selectors that derive its state based on the selected contextual network

Changelog

CHANGELOG entry:null

Related issues

Contributes to: #13674

Manual testing steps

NA

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0d834db
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4008c856-7aa8-412e-a7e6-046ee4402ecd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 257e5a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e799119-bc6f-49b9-90c1-42afb24184a4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vinnyhoward vinnyhoward added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 6, 2025
Cal-L
Cal-L approved these changes Aug 6, 2025
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 8460806 Aug 6, 2025
60 of 66 checks passed
@Cal-L Cal-L deleted the feat-4173-send-flow-contextual-network-related-selectors branch August 6, 2025 21:25
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@github-actions github-actions Bot added the needs-validation Post merge validation label Aug 6, 2025
@metamaskbot metamaskbot added the release-7.54.0 Issue or pull request that will be included in release 7.54.0 label Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

needs-validation Post merge validation No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinnyhoward @Cal-L @metamaskbot