Skip to content

ci: add RCA-needed label on RCA workflow#18032

Merged
jvbriones merged 2 commits into
mainfrom
chore-unify-ci-scripts
Aug 6, 2025
Merged

ci: add RCA-needed label on RCA workflow#18032
jvbriones merged 2 commits into
mainfrom
chore-unify-ci-scripts

Conversation

@jvbriones

@jvbriones jvbriones commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Description

3 changes on CI workflows:

  • avoid running add-team-label script for forks
  • RCA workflow updated to add RCA-needed labels
  • remove deprecated use of no-smoke-e2e tests on new PRs

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Aug 6, 2025
@jvbriones jvbriones changed the title ci: avoid running add-team-label script for forks ci: add RCA-needed label on RCA workflow Aug 6, 2025
@jvbriones jvbriones added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed needs-smoke-e2e No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 6, 2025
labels: ['No E2E Smoke Needed']
});
}
}); No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: PR Labeling Issue After Workflow Update

The auto-draft-prs.yml workflow unintentionally removed the automatic "No E2E Smoke Needed" label for pull requests with "docs:" in their title. This occurred as a side effect of changes aimed at modifying fork handling, which also removed the label for fork PRs.

Fix in Cursor Fix in Web

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

@jvbriones jvbriones added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 55c3437 Aug 6, 2025
73 of 78 checks passed
@jvbriones jvbriones deleted the chore-unify-ci-scripts branch August 6, 2025 15:11
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants