Skip to content

fix: add account_type property to the Wallet Created event cp-7.53.0#18024

Merged
chaitanyapotti merged 1 commit into
mainfrom
fix/account-type
Aug 6, 2025
Merged

fix: add account_type property to the Wallet Created event cp-7.53.0#18024
chaitanyapotti merged 1 commit into
mainfrom
fix/account-type

Conversation

@huggingbot

Copy link
Copy Markdown
Member

Description

Add account_type property to the Wallet Created metametrics event

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Aug 6, 2025
@huggingbot huggingbot added area-onboarding Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed team-onboarding Onboarding team labels Aug 6, 2025
@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4eca70c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b72b4f2-9b29-4a72-816d-36ac0c604ab5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@huggingbot huggingbot added the team-onboarding Onboarding team label Aug 6, 2025
@huggingbot huggingbot changed the title fix: add account_type property to metrics to the Wallet Created event fix: cp-7.53.0 add account_type property to the Wallet Created event Aug 6, 2025
@huggingbot huggingbot changed the title fix: cp-7.53.0 add account_type property to the Wallet Created event fix: add account_type property to the Wallet Created event cp-7.53.0 Aug 6, 2025
@huggingbot huggingbot marked this pull request as ready for review August 6, 2025 09:43
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 767c5ae Aug 6, 2025
85 of 98 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/account-type branch August 6, 2025 14:53
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: “Wallet Created” event missing account_type property (Google/Apple/SRP)

4 participants