Skip to content

feat: contextual network picker component#18014

Merged
vinnyhoward merged 3 commits into
mainfrom
feat-4173-contextual-network-picker-component
Aug 6, 2025
Merged

feat: contextual network picker component#18014
vinnyhoward merged 3 commits into
mainfrom
feat-4173-contextual-network-picker-component

Conversation

@vinnyhoward

Copy link
Copy Markdown
Contributor

Description

This is a part of a series of pull requests based off of this parent PR Send Flow with Contextual Chain Id

This PR introduces the contextual network picker for the send flow, its required to allow the user to select networks within the send flow, moving away from global network state dependency.

Changelog

CHANGELOG entry: Added new component for the contextual send flow

Related issues

Contributes to: #13674

Manual testing steps

NA

Screenshots/Recordings

This screen recording is from the parent PR, this PR doesn't put it in use yet

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-05.at.20.13.14.mp4

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 6, 2025
@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Aug 6, 2025
@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 51660bb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/662f22db-d393-44af-b012-8132a413f79e

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7ec82fb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e33d4802-e909-43c6-bde4-649ec569ec6d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit eecbe0f Aug 6, 2025
58 of 60 checks passed
@vinnyhoward vinnyhoward deleted the feat-4173-contextual-network-picker-component branch August 6, 2025 16:51
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@github-actions github-actions Bot added the needs-validation Post merge validation label Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-validation Post merge validation No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants