Skip to content

feat: redux infra for contextual chain id for send flow#18012

Merged
vinnyhoward merged 2 commits into
mainfrom
feat-4173-contextual-network-redux-infra
Aug 6, 2025
Merged

feat: redux infra for contextual chain id for send flow#18012
vinnyhoward merged 2 commits into
mainfrom
feat-4173-contextual-network-redux-infra

Conversation

@vinnyhoward

@vinnyhoward vinnyhoward commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This is a part of a series of pull requests based off of this parent PR Send Flow with Contextual Chain Id

This PR introduces the core state management infrastructure required to track and manage chain selection contextually within the send flow, moving away from global network state dependency. This foundation enables subsequent PRs to implement UI components and business logic that leverage contextual chain selection.

Changelog

CHANGELOG entry: Added state management for contextual send flow

Related issues

Contributes to: #13674

Manual testing steps

NA

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Aug 6, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 6, 2025
@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8ed02ce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82531311-d6d7-478f-9afc-d6bf9a04017c

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7f95855
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d33a90a7-ae1d-406b-9972-e454cf007f65

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]
cursor Bot reviewed Aug 6, 2025
View reviewed changes
Comment thread app/actions/sendFlow/index.ts
@codecov-commenter

codecov-commenter commented Aug 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.44%. Comparing base (419e421) to head (7f95855).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #18012      +/-   ##
==========================================
+ Coverage   74.41%   74.44%   +0.03%     
==========================================
  Files        2969     2994      +25     
  Lines       66997    67512     +515     
  Branches    11216    11342     +126     
==========================================
+ Hits        49853    50261     +408     
- Misses      13938    13997      +59     
- Partials     3206     3254      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L
Cal-L approved these changes Aug 6, 2025
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit afea189 Aug 6, 2025
58 of 60 checks passed
@vinnyhoward vinnyhoward deleted the feat-4173-contextual-network-redux-infra branch August 6, 2025 16:51
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@github-actions github-actions Bot added the needs-validation Post merge validation label Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

needs-validation Post merge validation No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vinnyhoward @codecov-commenter @Cal-L @metamaskbot @tommasini