feat: Add tp&sl lines to Perps chart#18005
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Matt561
left a comment
There was a problem hiding this comment.
I see in your demo that the TP/SL lines don't render initial and appear after changing the candle period. Is this intentional?
Otherwise LGTM! 👍
|
@gambinish Let's also fix that one minor SonarCloud issue about the unnecessary fragment if it's legit |
Yeah, so I'm not sure if we're going to find a way around this, unless we write a hack or something that sets and interval before rendering. The grid lines and tp/sl lines are both handled outside of the wagmi chart library's context, so they inevitably render in different times. I'll spend some time looking into this to see if I can make it any smoother. |
…necessary fragment
|
@Matt561 I've added a small timeout to render the tpsl lines after the candles load in. Feels like better UX that way |
|
Description
Adds TP&SL lines to Perps chart
Changelog
CHANGELOG entry: Adds TP&SL lines to Perps chart
Related issues
Fixes:
Manual testing steps
Create multiple perps positions, add Take Profit, Stop Loss prices. Lines should reflect these data points.
Screenshots/Recordings
Screen.Recording.2025-08-05.at.1.33.22.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist