Skip to content

feat(deposit): add networks filtering to token selector#17996

Merged
wachunei merged 5 commits into
mainfrom
feat/deposit-network-token-selector-modal
Aug 6, 2025
Merged

feat(deposit): add networks filtering to token selector#17996
wachunei merged 5 commits into
mainfrom
feat/deposit-network-token-selector-modal

Conversation

@wachunei

@wachunei wachunei commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR adds network filtering to the token selector of the deposit feature.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

network_filter_before.mp4

After

network_filter_after.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Aug 5, 2025
@wachunei wachunei marked this pull request as ready for review August 5, 2025 20:26
@wachunei wachunei requested a review from a team as a code owner August 5, 2025 20:26
cursor[bot]
cursor Bot reviewed Aug 5, 2025
View reviewed changes
Comment thread app/components/UI/Ramp/Deposit/hooks/useSearchTokenResults.ts
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9ff15b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f3a08f07-91df-497b-a624-1a10ef0e9ec1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added the QA Passed QA testing has been completed and passed label Aug 6, 2025
@wachunei wachunei enabled auto-merge August 6, 2025 14:19
@wachunei wachunei added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 8ba0ff6 Aug 6, 2025
57 of 62 checks passed
@wachunei wachunei deleted the feat/deposit-network-token-selector-modal branch August 6, 2025 14:36
@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Hi @wachunei,

on the day following feat or perf PR merge, PM and author to test changes on main (feature + exploratory around the edges) using the latest nightly build with casual user persona and also a power user persona where performance might be a challenge. Please record the testing in a video, check the relevant post-merge checklist box below, and post the video in a comment at the bottom of this PR.

Author validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

PM validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@github-actions github-actions Bot added the needs-validation Post merge validation label Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

+1 more reviewer

@AxelGes AxelGes AxelGes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-validation Post merge validation QA Passed QA testing has been completed and passed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wachunei @AxelGes @metamaskbot @tommasini