Skip to content

feat: update perps trading tooltips#17942

Merged
abretonc7s merged 27 commits into
mainfrom
feat/perps-tat-1250
Aug 6, 2025
Merged

feat: update perps trading tooltips#17942
abretonc7s merged 27 commits into
mainfrom
feat/perps-tat-1250

Conversation

@abretonc7s

@abretonc7s abretonc7s commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description

Updated tooltip modals in PerpsOrderView to match the latest design specifications. Added "Got it" buttons
to all tooltips for better user experience and updated copy to provide clearer educational content. Also
removed the execution time tooltip as it's no longer needed.

Changelog

CHANGELOG entry: Updated Perps trading tooltips with improved copy and "Got it" buttons

Related issues

Fixes: TAT-1250

Manual testing steps

Feature: Perps Order View Tooltips
Scenario: User views tooltip information
Given user is on the Perps order screen
When user taps the info icon next to Leverage, Margin, Liquidation price, or Fees
Then tooltip modal appears with educational content and a "Got it" button
And pressing "Got it" closes the tooltip modal

Screenshots/Recordings

Before

  • Tooltips had generic "Close" button
  • Execution time tooltip was present
  • Copy didn't match latest design

After

  • All tooltips now have "Got it" button that properly closes the modal
  • Execution time tooltip removed
  • Updated copy matches design mockup
  • Dynamic fee rates displayed for provider fees
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-05.at.21.08.39.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and
    includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-sdk-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Aug 5, 2025
@abretonc7s abretonc7s changed the base branch from main to feat/perps-edge-cases August 5, 2025 13:12
@abretonc7s abretonc7s added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed team-perps Perps team and removed team-sdk-deprecated DEPRECATED: please use "team-wallet-integrations" instead labels Aug 5, 2025
@abretonc7s abretonc7s changed the title Feat/perps tat 1250 feat: update perps trading tooltips Aug 5, 2025
@abretonc7s abretonc7s marked this pull request as ready for review August 5, 2025 13:13
@abretonc7s abretonc7s requested a review from a team as a code owner August 5, 2025 13:13
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

nickewansmith
nickewansmith previously approved these changes Aug 5, 2025
gambinish
gambinish previously approved these changes Aug 5, 2025
@abretonc7s abretonc7s added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Aug 6, 2025
Base automatically changed from feat/perps-edge-cases to main August 6, 2025 02:17
@abretonc7s abretonc7s dismissed stale reviews from nickewansmith and gambinish August 6, 2025 02:17

The base branch was changed.

@abretonc7s abretonc7s enabled auto-merge August 6, 2025 02:25
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
64.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@abretonc7s abretonc7s added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 5a5d4a0 Aug 6, 2025
43 of 44 checks passed
@abretonc7s abretonc7s deleted the feat/perps-tat-1250 branch August 6, 2025 03:00
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants