Skip to content

ci: post validation bot to add a checklist in feat and perf PRs#17937

Merged
jvbriones merged 16 commits into
mainfrom
chore-post-validation
Aug 6, 2025
Merged

ci: post validation bot to add a checklist in feat and perf PRs#17937
jvbriones merged 16 commits into
mainfrom
chore-post-validation

Conversation

@jvbriones

@jvbriones jvbriones commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add a workflow to add a comment in the feat and perf PRs asking for a validation in main once they get merged.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Aug 5, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov-commenter

codecov-commenter commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.40%. Comparing base (419e421) to head (bfe68ae).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17937      +/-   ##
==========================================
- Coverage   74.41%   74.40%   -0.01%     
==========================================
  Files        2969     2975       +6     
  Lines       66997    67062      +65     
  Branches    11216    11238      +22     
==========================================
+ Hits        49853    49897      +44     
- Misses      13938    13947       +9     
- Partials     3206     3218      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by jvbriones
Loading

Copy link
Copy Markdown
Contributor

Hi @jvbriones,

This PR has been merged to the main branch. Please ensure the following validation steps are completed.
Please use power user persona where performance might be a challenge.

Validation Checklist

  • Author validated the changes in main branch using the nightly build
  • PM of the team validated the changes in main branch using the nightly build
  • Video URL shared:

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by jvbriones
Loading

Copy link
Copy Markdown
Contributor

Hi @jvbriones,

On the day following feat or perf PR merge, PM and author to test feature on main (feature+exploratory around the edges) using the latest nightly build with casual user persona and also a power user persona where performance might be a challenge. Record a video, check the relevant post-merge checklist box below, and post the video in the relevant comment at the bottom of the PR.

Author validation checklist

  • Validated the changes in main branch using the nightly build
  • Video URL shared

PM validation checklist

  • Validated the changes in main branch using the nightly build
  • Video URL shared

@github-actions github-actions Bot added the needs-validation Post merge validation label Aug 5, 2025
@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by jvbriones
Loading

Copy link
Copy Markdown
Contributor

Hi @jvbriones,

on the day following feat or perf PR merge, PM and author to test changes on main (feature + exploratory around the edges) using the latest nightly build with casual user persona and also a power user persona where performance might be a challenge. Please record the testing in a video, check the relevant post-merge checklist box below, and post the video in a comment at the bottom of this PR.

Author validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

PM validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Hi @jvbriones,

On the day following feat or perf PR merge, PM and author to test changes on main (feature + exploratory around the edges) using the latest nightly build with casual user persona and also a power user persona where performance might be a challenge. Please record the testing in a video, check the relevant post-merge checklist box below, and post the video in a comment at the bottom of this PR.

Author validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

PM validation checklist

  • Validated the changes in main branch using the nightly build
  • Video shared

cursor[bot]

This comment was marked as outdated.

Sign in to view

@jvbriones jvbriones changed the title chore: add post merge validation bot ci: post validation bot to add a checklist in feat and perf PRs Aug 6, 2025
@jvbriones jvbriones added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed No E2E Smoke Needed No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 6, 2025
@jvbriones jvbriones enabled auto-merge August 6, 2025 11:07
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jvbriones jvbriones added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 6e1868c Aug 6, 2025
71 of 76 checks passed
@jvbriones jvbriones deleted the chore-post-validation branch August 6, 2025 11:25
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

Assignees

No one assigned

Labels

needs-validation Post merge validation No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jvbriones @codecov-commenter @christopherferreira9 @metamaskbot @tommasini