Skip to content

fix: synced srp discover accounts - cp-7.53.0#17925

Merged
ieow merged 3 commits into
mainfrom
feat/synced-srp-discover-account
Aug 6, 2025
Merged

fix: synced srp discover accounts - cp-7.53.0#17925
ieow merged 3 commits into
mainfrom
feat/synced-srp-discover-account

Conversation

@ieow

@ieow ieow commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description

synced srp from seedless onboarding missing multichain account discovery
This PR add the multichain accounts discovery upon new synced srp

Changelog

CHANGELOG entry:

Related issues

Fixes:
#18025
#18420

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2025-08-05 at 3 53 07 PM

After

Screenshot 2025-08-05 at 2 55 25 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Aug 5, 2025
@ieow ieow marked this pull request as ready for review August 5, 2025 09:02
cursor[bot]

This comment was marked as outdated.

@ieow ieow self-assigned this Aug 5, 2025
@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5fa64d4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c341167d-b58d-44e8-9d06-4b02a47c77f2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@ieow ieow changed the title fix: synced srp discover accounts fix: synced srp discover accounts - cp-7.53.0 Aug 6, 2025
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

@chaitanyapotti chaitanyapotti added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Aug 6, 2025
@chaitanyapotti chaitanyapotti added area-onboarding area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. labels Aug 6, 2025
@LeVinhGithub LeVinhGithub added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 6, 2025
@LeVinhGithub

Copy link
Copy Markdown
Contributor

lgtm

@ieow ieow added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit a012669 Aug 6, 2025
81 of 90 checks passed
@ieow ieow deleted the feat/synced-srp-discover-account branch August 6, 2025 09:12
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. QA Passed QA testing has been completed and passed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants