Skip to content

feat: Integrate Rive animation library#17919

Merged
Cal-L merged 8 commits into
mainfrom
prototype/rive
Aug 5, 2025
Merged

feat: Integrate Rive animation library#17919
Cal-L merged 8 commits into
mainfrom
prototype/rive

Conversation

@Cal-L

@Cal-L Cal-L commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds the Rive animation library to mobile as well as documentation on loading both local and remote assets. One major difference between Rive and Lottie is Rive's ability to use state machines. This enables us to perform non linear animations such as transitioning smoothly from point A to point C.

Changelog

CHANGELOG entry:

Related issues

Fixes: #17636

Manual testing steps

Follow instructions in animations documentation on how to load Rive assets

Screenshots/Recordings

Before

After

PoC where top fox is Lottie and bottom is Rive. Asset loaded locally

rive-fox.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team August 4, 2025 20:52
@github-actions

github-actions Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Aug 4, 2025
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 4, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Aug 4, 2025
@socket-security

socket-security Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addednpm/​rive-react-native@​9.3.4991009589100

View full report

@github-actions

github-actions Bot commented Aug 4, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 494cc09
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60db4012-0f52-4779-8eeb-9423c322a8bf

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Cal-L Cal-L enabled auto-merge August 4, 2025 20:58
nickewansmith
nickewansmith previously approved these changes Aug 4, 2025
View reviewed changes

@nickewansmith nickewansmith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tommasini
tommasini previously approved these changes Aug 4, 2025
View reviewed changes
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Aug 4, 2025
@github-actions

github-actions Bot commented Aug 4, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 495a87e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c1b2ff92-8e47-4dca-afbc-16e65d0bc422

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Cal-L Cal-L dismissed stale reviews from tommasini and nickewansmith via c3c464f August 4, 2025 22:41
@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 60a483e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e5ab34b-427e-4690-ae84-2be8f0f5f11f

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L

Cal-L commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

Failing E2E not related to Rive library

@Cal-L Cal-L added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 3eebeb8 Aug 5, 2025
71 of 74 checks passed
@Cal-L Cal-L deleted the prototype/rive branch August 5, 2025 23:45
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 5, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 5, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 5, 2025
@sethkfman sethkfman added the area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. label Aug 21, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gambinish gambinish gambinish approved these changes

@tommasini tommasini tommasini approved these changes

+1 more reviewer

@nickewansmith nickewansmith nickewansmith left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement and Evaluate Rive Animations for Enhanced User Experience

7 participants

@Cal-L @nickewansmith @gambinish @tommasini @gauthierpetetin @sethkfman @metamaskbot