Skip to content

chore: map android signing-configs to auth environments for flask and main#17868

Merged
Cal-L merged 5 commits into
mainfrom
chore/keystore-signing-update
Aug 6, 2025
Merged

chore: map android signing-configs to auth environments for flask and main#17868
Cal-L merged 5 commits into
mainfrom
chore/keystore-signing-update

Conversation

@sethkfman

@sethkfman sethkfman commented Aug 1, 2025 •
edited by Cal-L
Loading

Copy link
Copy Markdown
Contributor

Description

This PR maps METAMASK_ENVIRONMENT environments to use the correct signing configs on Android. This is needed to support seedless onboarding features such as Google log in

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman added the team-mobile-platform Mobile Platform team label Aug 1, 2025
@sethkfman sethkfman requested a review from a team August 1, 2025 18:56
@github-actions

github-actions Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 1, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Aug 1, 2025
@github-actions

github-actions Bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e641ef9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c6e0c8b5-4ef2-4cce-9fd9-ef921a975df0

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4c1756f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/34acc0d1-59a4-48b6-b6c7-3890f158aa8e

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c9e6251
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9bcd96cc-f11e-4b4d-8664-eff855ef0b0b

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 48a09e7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee00deae-4e12-4ebe-b46e-54adb6a841d3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter

codecov-commenter commented Aug 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.39%. Comparing base (2e013c7) to head (48a09e7).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17868   +/-   ##
=======================================
  Coverage   74.38%   74.39%           
=======================================
  Files        2963     2965    +2     
  Lines       66950    66912   -38     
  Branches    11163    11188   +25     
=======================================
- Hits        49804    49777   -27     
+ Misses      13937    13925   -12     
- Partials     3209     3210    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Aug 1, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Aug 5, 2025
@Cal-L Cal-L enabled auto-merge August 5, 2025 23:28
@Cal-L Cal-L added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit f0a7c6e Aug 6, 2025
66 of 69 checks passed
@Cal-L Cal-L deleted the chore/keystore-signing-update branch August 6, 2025 00:17
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 6, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@weitingsun weitingsun weitingsun approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sethkfman @codecov-commenter @weitingsun @gauthierpetetin @Cal-L @metamaskbot @tommasini