feat: Adding solana infrastructure to send page by jpuri · Pull Request #17771 · MetaMask/metamask-mobile

jpuri · 2025-07-31T15:16:07Z

Description

Use new send flow for solana assets.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5463

Manual testing steps

Enable new send flow locally
Start send on solana network
Check new send page rendered

Screenshots/Recordings

Screen.Recording.2025-08-02.at.10.24.34.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-31T15:16:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov-commenter · 2025-08-06T06:49:18Z

Codecov Report

❌ Patch coverage is 89.76744% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.47%. Comparing base (4bb4d0f) to head (aac63e1).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...ations/hooks/send/evm/useEvmToAddressValidation.ts	90.00%	1 Missing and 4 partials ⚠️
app/components/hooks/useSendNonEvmAsset.ts	20.00%	3 Missing and 1 partial ⚠️
.../hooks/send/solana/useSolanaToAddressValidation.ts	85.00%	2 Missing and 1 partial ⚠️
...irmations/hooks/send/evm/useEvmAmountValidation.ts	92.00%	1 Missing and 1 partial ⚠️
...s/Views/confirmations/hooks/send/useSendActions.ts	60.00%	1 Missing and 1 partial ⚠️
...confirmations/hooks/send/useToAddressValidation.ts	80.00%	1 Missing and 1 partial ⚠️
...ws/confirmations/components/send/amount/amount.tsx	83.33%	0 Missing and 1 partial ⚠️
...ws/confirmations/hooks/send/evm/useEvmMaxAmount.ts	96.66%	0 Missing and 1 partial ⚠️
...nts/Views/confirmations/hooks/send/useMaxAmount.ts	80.00%	0 Missing and 1 partial ⚠️
...ents/Views/confirmations/hooks/send/useSendType.ts	90.90%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17771      +/-   ##
==========================================
+ Coverage   74.38%   74.47%   +0.08%     
==========================================
  Files        2985     3000      +15     
  Lines       67286    67659     +373     
  Branches    11289    11378      +89     
==========================================
+ Hits        50051    50386     +335     
- Misses      14006    14007       +1     
- Partials     3229     3266      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-08-06T08:41:42Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: aac63e1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56f2081b-9b66-45fd-8933-b14091fc0475

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-08-06T09:54:22Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4328e84
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675791a8-f575-43d4-b5f1-98df4ef8c00a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-08-06T10:08:55Z

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-08-06T11:30:34Z

Hi @jpuri,

on the day following feat or perf PR merge, PM and author to test changes on main (feature + exploratory around the edges) using the latest nightly build with casual user persona and also a power user persona where performance might be a challenge. Please record the testing in a video, check the relevant post-merge checklist box below, and post the video in a comment at the bottom of this PR.

Author validation checklist

Validated the changes in main branch using the nightly build
Video shared

PM validation checklist

Validated the changes in main branch using the nightly build
Video shared

metamaskbot added the team-confirmations Push issues to confirmations team label Jul 31, 2025

jpuri force-pushed the solana_infra branch from f4b6196 to 0ca9b06 Compare August 4, 2025 04:31

jpuri added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 4, 2025

jpuri marked this pull request as ready for review August 4, 2025 04:31

jpuri requested review from a team as code owners August 4, 2025 04:31