Skip to content

feat: adding fait conversion option on send page#17704

Merged
jpuri merged 110 commits into
mainfrom
fiat_conversion
Aug 6, 2025
Merged

feat: adding fait conversion option on send page#17704
jpuri merged 110 commits into
mainfrom
fiat_conversion

Conversation

@jpuri

@jpuri jpuri commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Description

Adding fait conversion toggle option on send page

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5454

Manual testing steps

  1. Enable new send locally
  2. Trigger a send flow and check fait toggle

Screenshots/Recordings

Screenshot 2025-07-29 at 5 48 18 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri added 30 commits July 18, 2025 22:18
@jpuri
Adding a very basic send page for new send implementation.
5f11618
@jpuri
update
b4f17b2
@jpuri
update
038ee79
@jpuri
Merge branch 'main' into adding_send_page
dc1cc8c
@jpuri
Pass the asset to send page using routing
0196338
@jpuri
update
000501a
@jpuri
update
d699f93
@jpuri
Merge branch 'adding_send_page' into send_asset
8d24f98
@jpuri
update
2c8010c
@jpuri
Merge branch 'send_asset' of https://github.com/MetaMask/metamask-mobile
9869665 
 into send_asset
@jpuri
update
da81161
@jpuri
update
1f7136e
@jpuri
update
4137aa0
@jpuri
update
02ee52f
@jpuri
update
ea4ec65
@jpuri
update
0cc7ac6
@jpuri
update
88cbdef
@jpuri
update
c93b80d
@jpuri
update
7a685c6
@jpuri
update
dcb51c9
@jpuri
update
f478174
@jpuri
Add support to submit evm transaction
e4adafc
@jpuri
Adding context to send pages
f8b93bb
@jpuri
update
61d8bed
@jpuri
update
dba45f7
@jpuri
Merge branch 'main' into adding_send_page
9601281
@jpuri
Merge branch 'adding_send_page' into send_asset
8d814d0
@jpuri
update
6c5633d
@jpuri
Merge branch 'send_asset' into send_context
aae2e7d
@jpuri
update
b215d73
@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 972e76a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5dd7b638-2790-4b67-bc7b-9be1f8e0fe7a

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 209bbac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ae28fc52-ec30-41f9-befb-9a238221bfb0

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@jpuri jpuri enabled auto-merge August 5, 2025 16:54
@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b9c8da1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f9495e5e-ed01-457b-978e-3f32a7aed182

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov-commenter

codecov-commenter commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.69231% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.41%. Comparing base (419e421) to head (b9c8da1).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...s/Views/confirmations/hooks/send/useConversions.ts 80.00% 0 Missing and 7 partials ⚠️
...ws/confirmations/components/send/amount/amount.tsx 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #17704    +/-   ##
========================================
  Coverage   74.41%   74.41%            
========================================
  Files        2969     2980    +11     
  Lines       66997    67159   +162     
  Branches    11216    11263    +47     
========================================
+ Hits        49853    49975   +122     
- Misses      13938    13958    +20     
- Partials     3206     3226    +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 60c79cd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e2c13db4-c921-43b5-bb21-73a1e0b4c519

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]
cursor Bot reviewed Aug 6, 2025
View reviewed changes
Comment thread app/components/Views/confirmations/hooks/send/useConversions.ts
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit fb72db5 Aug 6, 2025
58 of 60 checks passed
@jpuri jpuri deleted the fiat_conversion branch August 6, 2025 04:44
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpuri @codecov-commenter @OGPoyraz @metamaskbot @tommasini