Skip to content

feat: add initial perps deposit confirmation#17702

Merged
matthewwalsh0 merged 16 commits into
mainfrom
feat/perps-deposit-confirmation
Aug 6, 2025
Merged

feat: add initial perps deposit confirmation#17702
matthewwalsh0 merged 16 commits into
mainfrom
feat/perps-deposit-confirmation

Conversation

@matthewwalsh0

@matthewwalsh0 matthewwalsh0 commented Jul 29, 2025

Copy link
Copy Markdown
Member

Description

Add the initial structure for the Perps specific deposit transaction confirmation.

Specifically:

  • Add EditAmount component to support inline editing of token transfer amount.
  • Display estimated bridge time in PayWithRow component.
  • Support minimal display in GasFeeDetailsRow using new hideSpeed and fiatOnly props.
  • Return balance and additional amount properties from useTransactionRequiredToken hook.
  • Return additional fiat properties from useTransactionRequiredFiat hook.
  • Return decimals from useTransactionPayToken hook.
  • Use token decimals from state if available in useTokenAmount.
  • Support updating token amount in useTokenAmount via new updateTokenAmount callback.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #5498

Manual testing steps

Screenshots/Recordings

Before

After

Deposit

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 29, 2025
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from 14f2b59 to b33e915 Compare July 29, 2025 20:47
@matthewwalsh0 matthewwalsh0 force-pushed the feat/perps-deposit-confirmation branch from ac0a256 to 939eeb6 Compare July 29, 2025 21:55
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from d1d5a21 to 0837105 Compare August 1, 2025 12:39
@matthewwalsh0 matthewwalsh0 force-pushed the feat/perps-deposit-confirmation branch from 9446e88 to 397847c Compare August 1, 2025 14:32
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from 0a304a0 to 14ca8ea Compare August 1, 2025 21:36
@matthewwalsh0 matthewwalsh0 force-pushed the feat/perps-deposit-confirmation branch from 0e94ea0 to 29d1f52 Compare August 1, 2025 21:44
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch 3 times, most recently from 30fd9ed to 43a7c9b Compare August 5, 2025 20:11
Base automatically changed from feat/transaction-pay-hook to main August 6, 2025 08:59
@matthewwalsh0 matthewwalsh0 force-pushed the feat/perps-deposit-confirmation branch from d50c296 to 03ddd7b Compare August 6, 2025 09:18
@matthewwalsh0 matthewwalsh0 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Aug 6, 2025
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review August 6, 2025 09:26
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner August 6, 2025 09:26
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner August 6, 2025 09:26
@matthewwalsh0 matthewwalsh0 changed the title feat: add perps deposit confirmation feat: add initial perps deposit confirmation Aug 6, 2025
cursor[bot]

This comment was marked as outdated.

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 03ddd7b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/402d831a-d611-4f26-981f-3d2295557edc

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fd36024
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59f50f9c-1d8d-4af1-a4e0-09b9eec5373c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Comment thread app/components/Views/confirmations/hooks/useTokenAmount.ts
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

@matthewwalsh0 matthewwalsh0 added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 6, 2025
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit d2d8c4c Aug 6, 2025
59 of 66 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/perps-deposit-confirmation branch August 6, 2025 14:02
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@github-actions github-actions Bot added the needs-validation Post merge validation label Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-validation Post merge validation No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants