feat: perps transactions history by nickewansmith · Pull Request #17688 · MetaMask/metamask-mobile

nickewansmith · 2025-07-29T00:21:59Z

Description

What is the reason for the change?

We want to view the users transaction history for perps fills, orders and funding.

What is the improvement/solution?

Adds the perps transaction view as a tab in the current transactions view

Changelog

CHANGELOG entry: Added a new transactions view for perps fills, orders and user funding fees

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-1027

Manual testing steps

Go to the transactions history view
click on the Perps tab
Click on the orders and funding tabs and go back to the fills tab
Each tab list item should have a detail screen according to the figma design in ticket - new designs are in the Design folder at the bottom

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-08-05.at.02.28.21.mp4

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-29T00:22:11Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-08-05T06:09:13Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cde86970aeb5242157a46486dc0fdc3cb5999383
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/19a8d907-eeed-4d0f-aee0-65c924abe33e

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

codecov-commenter · 2025-08-05T06:46:36Z

Codecov Report

❌ Patch coverage is 67.28972% with 140 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.36%. Comparing base (419e421) to head (1ae9eb8).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...Perps/controllers/providers/HyperLiquidProvider.ts	0.00%	67 Missing ⚠️
...ws/PerpsTransactionsView/PerpsTransactionsView.tsx	72.58%	29 Missing and 5 partials ⚠️
...components/UI/Perps/utils/transactionTransforms.ts	84.50%	2 Missing and 9 partials ⚠️
...components/UI/Perps/controllers/PerpsController.ts	0.00%	6 Missing ⚠️
app/components/UI/Perps/hooks/usePerpsTrading.ts	33.33%	6 Missing ⚠️
app/components/UI/Navbar/index.js	0.00%	5 Missing ⚠️
app/components/Views/ActivityView/index.js	44.44%	5 Missing ⚠️
app/components/UI/Perps/Views/PerpsView.tsx	0.00%	2 Missing ⚠️
app/components/Nav/Main/MainNavigator.js	0.00%	1 Missing ⚠️
...psTransactionsView/PerpsFundingTransactionView.tsx	96.00%	0 Missing and 1 partial ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17688      +/-   ##
==========================================
- Coverage   74.41%   74.36%   -0.05%     
==========================================
  Files        2969     2978       +9     
  Lines       66997    67423     +426     
  Branches    11216    11321     +105     
==========================================
+ Hits        49853    50141     +288     
- Misses      13938    14057     +119     
- Partials     3206     3225      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gambinish · 2025-08-05T18:50:39Z

Can you help me understand why these encoding changes are necessary?

I will remove this, it keeps popping up locally and getting included.

Reminder to remove this before merging

…d, dedupe screens

github-actions · 2025-08-06T18:19:02Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cbc9fc8f144cc0cf4675955a3eb0d24bf94442c3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9fc5fd20-6d5c-4f68-868d-6bd6b94e49cb

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

nickewansmith · 2025-08-06T20:59:05Z

I have added a minimal change here that does not affect output. Bitrise tests were mostly passing before this across runs, and collectively across runs have passed all tests.

cursor · 2025-08-06T21:13:26Z

Bug: Font File Encoding Accidentally Changed

Unintended changes in ios/MetaMask.xcodeproj/project.pbxproj modified the fileEncoding property from undefined to 9 for multiple custom font files (e.g., MM Sans, Geist fonts). These accidental changes are unrelated to the Perps transaction history feature and should be reverted.

sonarqubecloud · 2025-08-06T21:30:12Z

Quality Gate failed

Failed conditions
79.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

nickewansmith force-pushed the TAT-1027-as-a-user-i-can-view-my-transaction-history branch 2 times, most recently from b0b46bb to 680f89a Compare August 4, 2025 23:36

nickewansmith changed the title ~~chore: wip~~ feat: perps transactions history Aug 5, 2025

nickewansmith marked this pull request as ready for review August 5, 2025 06:06

nickewansmith requested a review from a team as a code owner August 5, 2025 06:06

nickewansmith force-pushed the TAT-1027-as-a-user-i-can-view-my-transaction-history branch from 035e960 to cde8697 Compare August 5, 2025 06:08

nickewansmith added team-perps Perps team Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 5, 2025

This comment was marked as outdated.

Sign in to view

nickewansmith force-pushed the TAT-1027-as-a-user-i-can-view-my-transaction-history branch from b30a821 to 1ae9eb8 Compare August 5, 2025 07:31

abretonc7s previously requested changes Aug 5, 2025

View reviewed changes