Skip to content

feat: add pay publish hook#17659

Merged
matthewwalsh0 merged 7 commits into
mainfrom
feat/transaction-pay-hook
Aug 6, 2025
Merged

feat: add pay publish hook#17659
matthewwalsh0 merged 7 commits into
mainfrom
feat/transaction-pay-hook

Conversation

@matthewwalsh0

@matthewwalsh0 matthewwalsh0 commented Jul 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Add a PublishHook to the TransactionController that submits bridge transactions for any quotes associated with the transaction.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #5432

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 28, 2025
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-bridge-quotes branch from e04c149 to 1d27d5c Compare July 29, 2025 12:33
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from 14f2b59 to b33e915 Compare July 29, 2025 20:47
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-bridge-quotes branch from 65932fe to f59b127 Compare July 31, 2025 08:11
Base automatically changed from feat/transaction-bridge-quotes to main July 31, 2025 10:16
@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from d1d5a21 to 0837105 Compare August 1, 2025 12:39
@matthewwalsh0 matthewwalsh0 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Aug 1, 2025
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review August 1, 2025 14:28
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner August 1, 2025 14:28
@matthewwalsh0 matthewwalsh0 requested a review from a team August 1, 2025 14:28
@github-actions

github-actions Bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0a304a0e8f9e1f8e6a4dac52ffde6c5aa363275f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/139001cb-d8f8-4fe0-bfbf-918384d4f35f

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from 0a304a0 to 14ca8ea Compare August 1, 2025 21:36
@github-actions

github-actions Bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 14ca8ea
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/852fa09f-41d6-4c6a-a1b5-f303cb3fe26c

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from 14ca8ea to 4877b01 Compare August 5, 2025 09:31
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4877b01141d967335d42ce44f58b817876bcc291
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16d84e4e-1f0e-452b-bf50-585b3a429da1

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter

codecov-commenter commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.42%. Comparing base (419e421) to head (4877b01).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
app/util/transactions/hooks/pay-hook.ts 93.47% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17659      +/-   ##
==========================================
+ Coverage   74.41%   74.42%   +0.01%     
==========================================
  Files        2969     2970       +1     
  Lines       66997    67044      +47     
  Branches    11216    11219       +3     
==========================================
+ Hits        49853    49896      +43     
- Misses      13938    13940       +2     
- Partials     3206     3208       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from 4877b01 to 30fd9ed Compare August 5, 2025 12:22
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 30fd9ed2054ab64ea41bed342220c33d03a89953
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c981331-50f6-421e-958b-a2b66bac29ab

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 force-pushed the feat/transaction-pay-hook branch from 30fd9ed to 43a7c9b Compare August 5, 2025 20:11
@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 43a7c9b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/adf4d2ab-5bbf-4ebf-a550-0ab375ac8ad6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]
cursor Bot reviewed Aug 5, 2025
View reviewed changes
Comment thread app/util/transactions/hooks/pay-hook.test.ts
Comment thread app/util/transactions/hooks/pay-hook.ts
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matthewwalsh0 matthewwalsh0 added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 5, 2025
@matthewwalsh0 matthewwalsh0 enabled auto-merge August 5, 2025 21:14
@matthewwalsh0 matthewwalsh0 requested a review from tommasini August 5, 2025 21:35
@matthewwalsh0

matthewwalsh0 commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

Require mobile team review just for new actions and events in:

app/core/Engine/messengers/transaction-controller-messenger/transaction-controller-messenger.ts

Thanks!

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit a495655 Aug 6, 2025
86 of 94 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/transaction-pay-hook branch August 6, 2025 08:59
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@vinistevam vinistevam vinistevam approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthewwalsh0 @codecov-commenter @OGPoyraz @vinistevam @tommasini @metamaskbot