Skip to content

test: cp-7.52.0 handle multichain account rename flows #17494

Merged
cmd-ob merged 3 commits into
mainfrom
fix/multichain-ui-e2e
Jul 23, 2025
Merged

test: cp-7.52.0 handle multichain account rename flows #17494
cmd-ob merged 3 commits into
mainfrom
fix/multichain-ui-e2e

Conversation

@cmd-ob

@cmd-ob cmd-ob commented Jul 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds test coverage for multichain account rename flows. Includes proper feature flag mocking and covers both enabled/disabled scenarios.

Updates renameActiveAccount method to handle both UIs

Update

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Jul 23, 2025
@github-actions

github-actions Bot commented Jul 23, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a8c6228
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6e7c9f4-d163-44db-a476-19f54ddea9b9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cmd-ob cmd-ob added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 23, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@cmd-ob cmd-ob requested a review from a team as a code owner July 23, 2025 12:04
cursor[bot]

This comment was marked as outdated.

Sign in to view

@tommasini tommasini changed the title test: handle multichain account rename flows test: cp-752-0 handle multichain account rename flows Jul 23, 2025
@tommasini tommasini changed the title test: cp-752-0 handle multichain account rename flows test: cp-7.52.0 handle multichain account rename flows Jul 23, 2025
cursor[bot]
cursor Bot reviewed Jul 23, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Bypasses Account Renaming Auto-Detection

The tests bypass the auto-detection logic for account renaming by directly calling renameActiveAccountLegacy() and renameActiveAccountMultichain(). They should instead use the main renameActiveAccount() method to properly test the feature flag-driven UI flow selection based on UI visibility.

e2e/specs/accounts/rename-account-flows.spec.ts#L49-L51

metamask-mobile/e2e/specs/accounts/rename-account-flows.spec.ts

Lines 49 to 51 in 289b0e8

await AccountListBottomSheet.tapEditAccountActionsAtIndex(0);
await AccountActionsBottomSheet.renameActiveAccountLegacy(
NEW_ACCOUNT_NAME,

e2e/specs/accounts/rename-account-flows.spec.ts#L105-L107

metamask-mobile/e2e/specs/accounts/rename-account-flows.spec.ts

Lines 105 to 107 in 289b0e8

await AccountListBottomSheet.tapEditAccountActionsAtIndex(0);
await AccountActionsBottomSheet.renameActiveAccountMultichain(
NEW_ACCOUNT_NAME,

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@sonarqubecloud

sonarqubecloud Bot commented Jul 23, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cmd-ob cmd-ob enabled auto-merge July 23, 2025 13:00
@cmd-ob cmd-ob added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 23, 2025
@cmd-ob cmd-ob added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 078a2c7 Jul 23, 2025
56 of 58 checks passed
@cmd-ob cmd-ob deleted the fix/multichain-ui-e2e branch July 23, 2025 13:53
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@montelaidev montelaidev montelaidev approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmd-ob @montelaidev @metamaskbot