Skip to content

chore: cp-7.52.0 assets controllers patch and bump form-data dependency#17444

Merged
tommasini merged 4 commits into
mainfrom
chore/assets-patch-and-bump-form-data
Jul 22, 2025
Merged

chore: cp-7.52.0 assets controllers patch and bump form-data dependency#17444
tommasini merged 4 commits into
mainfrom
chore/assets-patch-and-bump-form-data

Conversation

@tommasini

@tommasini tommasini commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

assets controllers patch and bump form-data dependency

Assets patch pr: #17442
form-data dept bump: #17434

Address other patch package issues!

Remove detox patch
react native crypto patch version
request dependency does not exist anymore

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team July 22, 2025 09:42
@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 22, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Jul 22, 2025
@github-actions

github-actions Bot commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​es-set-tostringtag@​2.0.3 ⏵ 2.1.06710083 +452100

View full report

salimtb
salimtb previously approved these changes Jul 22, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b576787
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29cb2a3a-1a6b-470c-b36b-4c6ea5745a46

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Andepande
Andepande previously approved these changes Jul 22, 2025
View reviewed changes

@Andepande Andepande left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we'll wait for the E2e

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 22, 2025
MarioAslau
MarioAslau previously approved these changes Jul 22, 2025
View reviewed changes
@tommasini
patch issues, assets controller patch version, transaction controller…
4930266 
… patch version, react native crypto patch version, request dependency does not exist anymore
@tommasini tommasini dismissed stale reviews from MarioAslau and Andepande via 4930266 July 22, 2025 11:16
@github-actions

github-actions Bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4930266
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e9e137b4-e541-4313-8754-53664f3a881f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Jul 22, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tommasini tommasini added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 91bd5b2 Jul 22, 2025
58 of 60 checks passed
@tommasini tommasini deleted the chore/assets-patch-and-bump-form-data branch July 22, 2025 12:53
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jul 22, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 22, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@MarioAslau MarioAslau MarioAslau approved these changes

@salimtb salimtb salimtb left review comments

+1 more reviewer

@Andepande Andepande Andepande left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tommasini @MarioAslau @salimtb @Andepande @gauthierpetetin @metamaskbot