Skip to content

chore: adding keypad story and allowing stories from other folders#17427

Merged
georgewrmarshall merged 3 commits into
mainfrom
fix/keypad-storybook
Jul 22, 2025
Merged

chore: adding keypad story and allowing stories from other folders#17427
georgewrmarshall merged 3 commits into
mainfrom
fix/keypad-storybook

Conversation

@georgewrmarshall

Copy link
Copy Markdown
Contributor

Description

This PR improves the Storybook configuration to be more flexible and inclusive, allowing stories to be created anywhere within the app/ directory structure. Previously, stories were limited to specific component library directories, which prevented the creation of stories for Base components and other UI elements outside the design system.

Changelog

CHANGELOG entry: Improved Storybook configuration to allow stories from any app directory and added Keypad component story

Related issues

Fixes: N/A
Improvement: Enables better component development workflow by allowing stories for Base components and other UI elements

Manual testing steps

  1. Run yarn storybook-generate to ensure story detection works
  2. Launch the app in Storybook mode
  3. Navigate to "Base Components / Keypad / Default" in Storybook
  4. Verify the Keypad story renders correctly with interactive functionality
  5. Test that existing component library stories still work as expected
  6. Confirm that stories can now be added to any component in the app/ directory

Screenshots/Recordings

Before

  • Stories were limited to component-library/components, component-library/base-components, and component-library/components-temp directories only
  • Keypad component had no isolated development environment

After

  • Stories can be created anywhere in the app/ directory structure
  • Keypad component now has a dedicated story for isolated development and testing
  • More flexible configuration supports future story additions across the entire app
after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall added No QA Needed Apply this label when your PR does not need any QA effort. team-design-system All issues relating to design system in Mobile No E2E Smoke Needed no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Jul 21, 2025
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Comment thread .storybook/main.js
Comment thread .storybook/storybook.requires.js
Comment thread app/components/Base/Keypad/Keypad.stories.tsx
@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 21, 2025 19:43
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Jul 22, 2025
@georgewrmarshall georgewrmarshall removed this pull request from the merge queue due to a manual request Jul 22, 2025
@sonarqubecloud

Copy link
Copy Markdown

@georgewrmarshall georgewrmarshall added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 19ef567 Jul 22, 2025
44 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/keypad-storybook branch July 22, 2025 19:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants