Skip to content

chore: cp-7.52.0 hardcode solana swaps liveness#17419

Merged
bfullam merged 5 commits into
mainfrom
swaps-1837-fix-swap-wallet-action-for-solana
Jul 22, 2025
Merged

chore: cp-7.52.0 hardcode solana swaps liveness#17419
bfullam merged 5 commits into
mainfrom
swaps-1837-fix-swap-wallet-action-for-solana

Conversation

@bfullam

@bfullam bfullam commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Currently, we check for swaps liveness by chainId through several feature flags. However, Solana is not included in any of those feature flags which causes incorrect behavior in the enabling of the swaps wallet action. This PR hardcodes Solana as a live network as a temporary solution until the feature flag pattern can be reevaluated in light of new networks being added.

Changelog

CHANGELOG entry:

Related issues

Fixes: #16319

Manual testing steps

  1. Go to Palm network
  2. Switch to Solana
  3. See swap wallet action is enabled

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Jul 21, 2025
@bfullam bfullam added QA Passed QA testing has been completed and passed Run Smoke E2E labels Jul 21, 2025
@bfullam bfullam marked this pull request as ready for review July 21, 2025 15:11
@github-actions

github-actions Bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 592a5c1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8f4fa9e7-d30d-4898-90da-7022c705af7c

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 684311d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e4bfbeed-6b6e-411f-a6e8-c033972ef5c0

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 95ebf90
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/baaa10bf-978a-407d-881d-ad77881f14c5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Jul 22, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bfullam bfullam added this pull request to the merge queue Jul 22, 2025
@bfullam bfullam removed this pull request from the merge queue due to a manual request Jul 22, 2025
@bfullam bfullam changed the title chore: hardcode solana swaps liveness chore: cp-7.52.0 hardcode solana swaps liveness Jul 22, 2025
@bfullam bfullam added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 1001dcb Jul 22, 2025
74 of 78 checks passed
@bfullam bfullam deleted the swaps-1837-fix-swap-wallet-action-for-solana branch July 22, 2025 16:58
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot

metamaskbot commented Sep 3, 2025

Copy link
Copy Markdown
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

13 similar comments
@metamaskbot

metamaskbot commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot

metamaskbot commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@SteP-n-s SteP-n-s SteP-n-s approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Swap main menu get disabled after changing the network from palm to solana

3 participants

@bfullam @metamaskbot @SteP-n-s