Skip to content

fix: cp-7.51.0 cp-7.52.0 Fix TokenHero component and put back e2e assertions#17403

Merged
OGPoyraz merged 6 commits into
mainfrom
ogp/5403
Jul 22, 2025
Merged

fix: cp-7.51.0 cp-7.52.0 Fix TokenHero component and put back e2e assertions#17403
OGPoyraz merged 6 commits into
mainfrom
ogp/5403

Conversation

@OGPoyraz

@OGPoyraz OGPoyraz commented Jul 21, 2025

Copy link
Copy Markdown
Member

Description

This PR aims to fix broken TokenHero component for native assets. Please see recording that all type of assets are shown properly in TokenHero component now.

It also puts back e2e assertions in place.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5403

Manual testing steps

  1. Try sending ETH
  2. See correct amount shown in the confirmation

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-07-21.at.10.48.43.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner July 21, 2025 07:58
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 21, 2025
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Jul 21, 2025
@github-actions

github-actions Bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f76126d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/920ce15e-ec68-4747-bb00-6c16acd5de79

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@OGPoyraz OGPoyraz changed the title fix: cp-7.51.0 cp-7.52.0 Fix TokenHero component and put back e2e assertions fix: cp-7.52.0 Fix TokenHero component and put back e2e assertions Jul 21, 2025
OGPoyraz
OGPoyraz commented Jul 21, 2025
View reviewed changes
Comment thread app/components/Views/confirmations/legacy/SendFlow/Amount/index.js
Comment thread e2e/specs/confirmations-redesigned/transactions/send-max-transfer.spec.ts
Comment thread app/components/Views/confirmations/components/rows/transactions/hero-row/hero-row.tsx
OGPoyraz
OGPoyraz commented Jul 21, 2025
View reviewed changes
Comment thread app/components/Views/confirmations/hooks/nft/useIsNft.ts Outdated
@OGPoyraz OGPoyraz changed the title fix: cp-7.52.0 Fix TokenHero component and put back e2e assertions fix: cp-7.52.0 cp-7.52.0 Fix TokenHero component and put back e2e assertions Jul 21, 2025
@OGPoyraz OGPoyraz changed the title fix: cp-7.52.0 cp-7.52.0 Fix TokenHero component and put back e2e assertions fix: cp-7.51.0 cp-7.52.0 Fix TokenHero component and put back e2e assertions Jul 21, 2025
@github-actions

github-actions Bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cd9822530d4c0c28c6971c463ed41524f900116d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/616cff78-5eab-4f77-9cf4-57435559fbe1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

vinistevam
vinistevam previously approved these changes Jul 21, 2025
View reviewed changes
@github-actions

github-actions Bot commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8aa6229
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d7aa5c3-5c7c-4a82-b129-a2f47860f527

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 323d33d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1cfe547f-aab9-4e21-8cc6-233e124e3361

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz requested review from jpuri and vinistevam July 22, 2025 07:11
@OGPoyraz OGPoyraz enabled auto-merge July 22, 2025 09:17
@github-actions

github-actions Bot commented Jul 22, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e2d59d5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/903f064c-af81-4ab8-b6a5-9e0fdd490ca1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Jul 22, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz OGPoyraz added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 09d0237 Jul 22, 2025
56 of 58 checks passed
@OGPoyraz OGPoyraz deleted the ogp/5403 branch July 22, 2025 15:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@jpuri jpuri jpuri approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OGPoyraz @jpuri @vinistevam @metamaskbot