Skip to content

chore: Refactor build configuration to use new build config as well as correct build targets#17397

Merged
Cal-L merged 67 commits into
mainfrom
chore/2238-update-qa-prod-build-config
Jul 31, 2025
Merged

chore: Refactor build configuration to use new build config as well as correct build targets#17397
Cal-L merged 67 commits into
mainfrom
chore/2238-update-qa-prod-build-config

Conversation

@Cal-L

@Cal-L Cal-L commented Jul 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updates the Bitrise workflows to use the new build configuration scripts. Some of the changes includes:

  • Decouple using QA for e2e tests
    • pr_smoke_e2e_pipeline will use main target
    • flask_smoke_e2e_pipeline will use flask target
  • Maintain backwards compatibility for e2e environment since it used qa before
  • Add scripts for test and e2e environments
  • Expose CONFIGURATION for Release or Debug for iOS binary generation
  • Use more unique naming for android gradle tasks - prefix with app:

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2257

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners July 19, 2025 02:39
@Cal-L Cal-L requested a review from a team July 19, 2025 02:39
@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Jul 19, 2025
@github-actions

github-actions Bot commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov-commenter

codecov-commenter commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.19%. Comparing base (1d80be6) to head (9ed5137).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
.../core/OAuthService/OAuthLoginHandlers/constants.ts 0.00% 1 Missing and 1 partial ⚠️
app/util/sentry/utils.js 0.00% 2 Missing ⚠️
app/components/Views/OnboardingCarousel/index.tsx 0.00% 0 Missing and 1 partial ⚠️
app/core/Performance/Performance.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #17397    +/-   ##
========================================
  Coverage   74.19%   74.19%            
========================================
  Files        2905     2916    +11     
  Lines       65745    65970   +225     
  Branches    10933    10968    +35     
========================================
+ Hits        48778    48946   +168     
- Misses      13806    13852    +46     
- Partials     3161     3172    +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vinnyhoward
vinnyhoward previously approved these changes Jul 30, 2025
View reviewed changes

@vinnyhoward vinnyhoward left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ieow
ieow approved these changes Jul 31, 2025
View reviewed changes

@ieow ieow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherferreira9
christopherferreira9 approved these changes Jul 31, 2025
View reviewed changes

@christopherferreira9 christopherferreira9 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing anything concerning with regards to e2e but a lot of tests failed in the last run, can we rebase with main to get a more stable version of the e2e? The flask tests were not fixed but the non flask smoke should pass or produce less issues. I'm approving anyway as this can be easily caught if we bump into other major issues.

cortisiko
cortisiko approved these changes Jul 31, 2025
View reviewed changes

@cortisiko cortisiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 31, 2025
@github-actions

github-actions Bot commented Jul 31, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8db2649
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c1c5b82-90be-449c-809d-f55a935b98f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]
cursor Bot reviewed Jul 31, 2025
View reviewed changes
Comment thread .detoxrc.js
@sonarqubecloud

sonarqubecloud Bot commented Jul 31, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Cal-L

Cal-L commented Jul 31, 2025

Copy link
Copy Markdown
Contributor Author

@christopherferreira9 Pulled from main and re-ran smoke - all is passing! https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c1c5b82-90be-449c-809d-f55a935b98f3

@Cal-L Cal-L enabled auto-merge July 31, 2025 19:52
@Cal-L Cal-L added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit d52fde7 Jul 31, 2025
53 of 60 checks passed
@Cal-L Cal-L deleted the chore/2238-update-qa-prod-build-config branch July 31, 2025 20:16
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 31, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2025
@github-actions github-actions Bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 31, 2025
@metamaskbot metamaskbot added the release-7.54.0 Issue or pull request that will be included in release 7.54.0 label Jul 31, 2025
@christopherferreira9 christopherferreira9 restored the chore/2238-update-qa-prod-build-config branch August 1, 2025 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@ieow ieow ieow approved these changes

@cortisiko cortisiko cortisiko approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.54.0 Issue or pull request that will be included in release 7.54.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Cal-L @codecov-commenter @darkwing @ieow @cortisiko @vinnyhoward @christopherferreira9 @FrederikBolding @gauthierpetetin @metamaskbot