Skip to content

feat(deposit): adds more tokens#17395

Merged
wachunei merged 11 commits into
mainfrom
feat/deposit-add-more-tokens
Jul 21, 2025
Merged

feat(deposit): adds more tokens#17395
wachunei merged 11 commits into
mainfrom
feat/deposit-add-more-tokens

Conversation

@wachunei

@wachunei wachunei commented Jul 18, 2025

Copy link
Copy Markdown
Member

Description

This PR adds more token definitions, but not enabled yet.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei requested a review from a team as a code owner July 18, 2025 21:39
@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d3c1312
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d925a58-4dc1-40b3-9dad-b800da2d4501

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 18, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 87fbe06
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5c28d8ce-f92d-490a-a5f0-a74b18c895b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Sign in to view

@wachunei wachunei added the QA Passed QA testing has been completed and passed label Jul 21, 2025
georgeweiler
georgeweiler previously approved these changes Jul 21, 2025
View reviewed changes
@wachunei wachunei added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@wachunei wachunei added this pull request to the merge queue Jul 21, 2025
@wachunei wachunei removed this pull request from the merge queue due to a manual request Jul 21, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f0472f3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60b00e4f-82a2-406f-bb6c-59e995ff33c9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]
cursor Bot reviewed Jul 21, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unverified Network Property Causes Null Return

The getCryptoCurrencyFromTransakId function is called with order.data.network without verifying its existence. Although order.data.cryptoCurrency is checked, the lack of a similar check for order.data.network means undefined can be passed, causing the function to incorrectly return null. This can lead to unexpected behavior, such as issues with analytics tracking.

app/components/UI/Ramp/Deposit/components/DepositOrderContent/DepositOrderContent.tsx#L63-L67

metamask-mobile/app/components/UI/Ramp/Deposit/components/DepositOrderContent/DepositOrderContent.tsx

Lines 63 to 67 in f0472f3

}
return getCryptoCurrencyFromTransakId(
order.data.cryptoCurrency,
order.data.network,
);

app/components/UI/Ramp/Deposit/Views/BankDetails/BankDetails.tsx#L217-L221

metamask-mobile/app/components/UI/Ramp/Deposit/Views/BankDetails/BankDetails.tsx

Lines 217 to 221 in f0472f3

const cryptoCurrency = getCryptoCurrencyFromTransakId(
order.data.cryptoCurrency,
order.data.network,
);

app/components/UI/Ramp/Deposit/Views/OrderProcessing/OrderProcessing.tsx#L95-L99

metamask-mobile/app/components/UI/Ramp/Deposit/Views/OrderProcessing/OrderProcessing.tsx

Lines 95 to 99 in f0472f3

if (hasDepositOrderField(order.data, 'cryptoCurrency')) {
const cryptoCurrency = getCryptoCurrencyFromTransakId(
(order.data as DepositOrder).cryptoCurrency,
(order.data as DepositOrder).network,
);

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@sonarqubecloud

sonarqubecloud Bot commented Jul 21, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wachunei wachunei added this pull request to the merge queue Jul 21, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2025
@wachunei wachunei added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit 0838425 Jul 21, 2025
54 checks passed
@wachunei wachunei deleted the feat/deposit-add-more-tokens branch July 21, 2025 20:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 21, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@georgeweiler georgeweiler georgeweiler left review comments

+1 more reviewer

@AxelGes AxelGes AxelGes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wachunei @georgeweiler @AxelGes @metamaskbot