feat(deposit): fixes routing after user is authenticated by georgeweiler · Pull Request #17393 · MetaMask/metamask-mobile

georgeweiler · 2025-07-18T20:57:16Z

Description

Updates the useDepositRouting hook to correctly follow the rules needed for maintaining user state when routing. Pages now call routeAfterAuthentication when they are routing which will take care of fetching forms for updated kyc status.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…rrectly

github-actions · 2025-07-18T20:57:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…it-routing-fixes

… status

…it-routing-fixes

github-actions · 2025-07-22T14:48:17Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b4fec3e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d9eacf46-ae7e-4d73-a271-a42291d19180

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…it-routing-fixes

socket-security · 2025-07-22T18:08:26Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@consensys/native-ramps-sdk@1.1.0 ⏵ 1.1.2	^-8			^-1	^-19

View full report

github-actions · 2025-07-22T19:30:11Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d241a07
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aa6d4390-4460-4be6-869e-59c56412a33c

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor

Bug: KYC Routing Flaws Cause Submission Errors

The KYC routing logic contains flaws in its form submission checks and recursive handling. Conditions like form?.isSubmitted === false or !form?.isSubmitted incorrectly evaluate when a form is not present in the requiredForms array, leading to missed routing (e.g., Basic Info, Additional Verification) or attempts to auto-submit non-existent forms (Purpose of Usage). Additionally, exceeding the recursive depth limit (5) for Purpose of Usage form submission causes routeAfterAuthentication to return early, leaving users stuck without further routing.

app/components/UI/Ramp/Deposit/hooks/useDepositRouting.ts#L402-L424

metamask-mobile/app/components/UI/Ramp/Deposit/hooks/useDepositRouting.ts

Lines 402 to 424 in d241a07

    
           // auto-submit purpose of usage form and then recursive call to route again 
        
           if (!getForm(TransakFormId.PURPOSE_OF_USAGE)?.isSubmitted) { 
        
             if (depth < 5) { 
        
               await submitPurposeOfUsage([ 
        
                 'Buying/selling crypto for investments', 
        
               ]); 
        
               await routeAfterAuthentication(quote, depth + 1); 
        
             } else { 
        
               Logger.error( 
        
                 new Error(`Submit of purpose depth exceeded: ${depth}`), 
        
               ); 
        
             } 
        
             return; 
        
           } 
        
           // if personal details or address form is not submitted, route to basic info 
        
           // SSN is always submitted with personal details for US users, so we don't need to check for it 
        
           const personalDetailsForm = getForm(TransakFormId.PERSONAL_DETAILS); 
        
           const addressForm = getForm(TransakFormId.ADDRESS); 
        
           if ( 
        
             personalDetailsForm?.isSubmitted === false || 
        
             addressForm?.isSubmitted === false 
        
           ) {

app/components/UI/Ramp/Deposit/hooks/useDepositRouting.ts#L436-L437

metamask-mobile/app/components/UI/Ramp/Deposit/hooks/useDepositRouting.ts

Lines 436 to 437 in d241a07

    
           const idProofForm = getForm(TransakFormId.ID_PROOF); 
        
           if (idProofForm?.isSubmitted === false) {

Fix in Cursor • Fix in Web

Bug: Analytics Event Timing Error

The RAMPS_OTP_CONFIRMED success analytics event is incorrectly tracked before routeAfterAuthentication(quote). This leads to inaccurate analytics, as the event is sent even if routing subsequently fails. The event should only be tracked after successful routing.

app/components/UI/Ramp/Deposit/Views/OtpCode/OtpCode.tsx#L176-L188

metamask-mobile/app/components/UI/Ramp/Deposit/Views/OtpCode/OtpCode.tsx

Lines 176 to 188 in d241a07

    
           try { 
        
             setIsLoading(true); 
        
             setError(null); 
        
             const response = await submitCode(); 
        
             if (!response) { 
        
               throw new Error('No response from submitCode'); 
        
             } 
        
             await setAuthToken(response); 
        
             trackEvent('RAMPS_OTP_CONFIRMED', { 
        
               ramp_type: 'DEPOSIT', 
        
               region: selectedRegion?.isoCode || '', 
        
             }); 
        
             await routeAfterAuthentication(quote);

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-22T19:47:40Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wachunei · 2025-07-22T21:16:04Z

Skipping e2e after 3 attemps

feat(deposit): fixes route after authentication to check for forms co…

8e853f4

…rrectly

metamaskbot added the team-money-movement issues related to Money Movement features label Jul 18, 2025

georgeweiler added 3 commits July 21, 2025 08:58

Merge branch 'main' of github.com:MetaMask/metamask-mobile into depos…

5b6d595

…it-routing-fixes

chore: cleaup and lint

cc6b137

chore: remove unnecessary diff

ffb7dd3

georgeweiler changed the title ~~feat(deposit): fixes route after authentication to check for forms co…~~ feat(deposit): fixes route after user is authenticated Jul 21, 2025

georgeweiler changed the title ~~feat(deposit): fixes route after user is authenticated~~ feat(deposit): fixes routing after user is authenticated Jul 21, 2025

georgeweiler added 5 commits July 21, 2025 11:36

chore: update enter address component to call route after authentiction

1b5a050

feat(deposit): updates to match architecture requirements

9cdfcb5

Merge branch 'main' of github.com:MetaMask/metamask-mobile into depos…

bcf7b20

…it-routing-fixes

feat(deposit): use form.isSubmitted property to check for correct kyc…

3ab5130

… status

Merge branch 'main' of github.com:MetaMask/metamask-mobile into depos…

b4fec3e

…it-routing-fixes

georgeweiler added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Jul 22, 2025

georgeweiler marked this pull request as ready for review July 22, 2025 14:47

georgeweiler requested a review from a team as a code owner July 22, 2025 14:47

This comment was marked as outdated.

Sign in to view

metamaskbot added the bitrise-result-ready label Jul 22, 2025

github-actions Bot removed the bitrise-result-ready label Jul 22, 2025

georgeweiler added 2 commits July 22, 2025 11:59

Merge branch 'main' of github.com:MetaMask/metamask-mobile into depos…

9c423f5

…it-routing-fixes

chore: bump ramp sdk

1fb2381

This comment was marked as outdated.

Sign in to view

chore: updates from review

d241a07

georgeweiler added Run Smoke E2E and removed Run Smoke E2E labels Jul 22, 2025

cursor Bot reviewed Jul 22, 2025

View reviewed changes

wachunei approved these changes Jul 22, 2025

View reviewed changes

georgeweiler enabled auto-merge July 22, 2025 19:46

georgeweiler added No E2E Smoke Needed and removed Run Smoke E2E labels Jul 22, 2025

georgeweiler added this pull request to the merge queue Jul 22, 2025

wachunei removed this pull request from the merge queue due to a manual request Jul 22, 2025

wachunei added Run Smoke E2E and removed No E2E Smoke Needed labels Jul 22, 2025

wachunei added No E2E Smoke Needed and removed Run Smoke E2E labels Jul 22, 2025

wachunei added this pull request to the merge queue Jul 22, 2025

Merged via the queue into main with commit 0ef5a5d Jul 22, 2025
77 of 80 checks passed

wachunei deleted the deposit-routing-fixes branch July 22, 2025 21:41

github-actions Bot locked and limited conversation to collaborators Jul 22, 2025

metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(deposit): fixes routing after user is authenticated#17393

feat(deposit): fixes routing after user is authenticated#17393
wachunei merged 12 commits into
mainfrom
deposit-routing-fixes

georgeweiler commented Jul 18, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

socket-security Bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

sonarqubecloud Bot commented Jul 22, 2025

Uh oh!

Uh oh!

wachunei commented Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// auto-submit purpose of usage form and then recursive call to route again
	if (!getForm(TransakFormId.PURPOSE_OF_USAGE)?.isSubmitted) {
	if (depth < 5) {
	await submitPurposeOfUsage([
	'Buying/selling crypto for investments',
	]);
	await routeAfterAuthentication(quote, depth + 1);
	} else {
	Logger.error(
	new Error(`Submit of purpose depth exceeded: ${depth}`),
	);
	}
	return;
	}

	// if personal details or address form is not submitted, route to basic info
	// SSN is always submitted with personal details for US users, so we don't need to check for it
	const personalDetailsForm = getForm(TransakFormId.PERSONAL_DETAILS);
	const addressForm = getForm(TransakFormId.ADDRESS);
	if (
	personalDetailsForm?.isSubmitted === false \|\|
	addressForm?.isSubmitted === false
	) {

	const idProofForm = getForm(TransakFormId.ID_PROOF);
	if (idProofForm?.isSubmitted === false) {

	try {
	setIsLoading(true);
	setError(null);
	const response = await submitCode();
	if (!response) {
	throw new Error('No response from submitCode');
	}
	await setAuthToken(response);
	trackEvent('RAMPS_OTP_CONFIRMED', {
	ramp_type: 'DEPOSIT',
	region: selectedRegion?.isoCode \|\| '',
	});
	await routeAfterAuthentication(quote);

Uh oh!

Conversation

georgeweiler commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

socket-security Bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 22, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: KYC Routing Flaws Cause Submission Errors

Bug: Analytics Event Timing Error

Uh oh!

sonarqubecloud Bot commented Jul 22, 2025

Quality Gate passed

Uh oh!

Uh oh!

wachunei commented Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

georgeweiler commented Jul 18, 2025 •

edited

Loading

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading

socket-security Bot commented Jul 22, 2025 •

edited

Loading

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading