fix: balance stuck in loading state. by darioAnongba · Pull Request #17372 · MetaMask/metamask-mobile

darioAnongba · 2025-07-18T13:41:41Z

Description

Fixes bug where native balances are not displayed for non EVM accounts on the accounts list because we try fetching the balance of the current selected network instead of the network of the account.

Changelog

CHANGELOG entry: Fixes bug where native balances are not displayed for non EVM accounts on the accounts list

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NWNT-408

Manual testing steps

Create Bitcoin account
Create Solana account
Navigate to Solana or Bitcoin account
See Bitcoin account balance displayed

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 16 Pro - 2025-07-18 at 15 42 49

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-18T13:41:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

2

…obile into fix/balances-bitcoin

cursor

Bug: Native Token Balance Overwrite Bug

The getMultichainNetworkAggregatedBalance function processes all assets for an account. If an account holds native assets from multiple chains (e.g., Bitcoin and Solana), the totalNativeTokenBalance is repeatedly overwritten during asset iteration. This causes only the balance of the last native asset processed to be retained, leading to data loss and non-deterministic, incorrect native token balance reporting.

app/selectors/multichain/multichain.ts#L292-L314

metamask-mobile/app/selectors/multichain/multichain.ts

Lines 292 to 314 in ce55051

    
           for (const assetId of assetIds) { 
        
             const { chainId } = parseCaipAssetType(assetId); 
        
             const nativeAssetId = 
        
               AVAILABLE_MULTICHAIN_NETWORK_CONFIGURATIONS[ 
        
                 chainId as SupportedCaipChainId 
        
               ]?.nativeCurrency; 
        
             const balance = balances[assetId] || { amount: '0', unit: '' }; 
        
             // Safely handle undefined rate 
        
             const rate = multichainAssetsRates?.[assetId]?.rate; 
        
             const balanceInFiat = 
        
               balance.amount && rate 
        
                 ? new BigNumber(balance.amount).times(rate) 
        
                 : new BigNumber(0); 
        
             fiatBalances[assetId] = balanceInFiat.toString(); 
        
             // If the asset is the native asset of the chain, set it as total native token balance 
        
             // This assumes the account is always on the same chain (excludes testnets) 
        
             if (assetId === nativeAssetId) { 
        
               totalNativeTokenBalance = balance; 
        
             }

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

codecov-commenter · 2025-07-22T14:20:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.77%. Comparing base (5184987) to head (ce55051).
Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17372      +/-   ##
==========================================
+ Coverage   73.57%   73.77%   +0.20%     
==========================================
  Files        2845     2852       +7     
  Lines       63338    63814     +476     
  Branches    10328    10445     +117     
==========================================
+ Hits        46598    47076     +478     
+ Misses      13741    13707      -34     
- Partials     2999     3031      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud · 2025-07-22T14:21:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-07-22T15:11:47Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ce55051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/77a0c73b-1597-479f-8997-9f8e3a2c8d02

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

bug fixed, before tests

bcf013d

darioAnongba self-assigned this Jul 18, 2025

metamaskbot added the team-networks Networks team label Jul 18, 2025

remove more

c9f9774

darioAnongba added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 18, 2025

darioAnongba added 3 commits July 18, 2025 16:33

remove unnecessary test2

2166439

2

console log

3ace8ef

Merge branch 'main' into fix/balances-bitcoin

ddf8c9b

darioAnongba marked this pull request as ready for review July 18, 2025 14:46

darioAnongba requested a review from a team as a code owner July 18, 2025 14:46

Merge branch 'fix/balances-bitcoin' of github.com:MetaMask/metamask-m…

0e2ace0

…obile into fix/balances-bitcoin

This comment was marked as outdated.

Sign in to view

rebase

7c702c7

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into fix/balances-bitcoin

6d026dd

This comment was marked as outdated.

Sign in to view

unit

a271eb2

This comment was marked as outdated.

Sign in to view

remove unecessary dependency

ce55051

cursor Bot reviewed Jul 22, 2025

View reviewed changes

darioAnongba added the Run Smoke E2E label Jul 22, 2025

metamaskbot added the bitrise-result-ready label Jul 22, 2025

github-actions Bot removed the bitrise-result-ready label Jul 22, 2025

zone-live approved these changes Jul 22, 2025

View reviewed changes

darioAnongba commented Jul 22, 2025

View reviewed changes

Comment thread app/selectors/multichain/multichain.test.ts

brianacnguyen approved these changes Jul 22, 2025

View reviewed changes

darioAnongba added this pull request to the merge queue Jul 22, 2025

Merged via the queue into main with commit ee7b314 Jul 22, 2025
54 of 56 checks passed

darioAnongba deleted the fix/balances-bitcoin branch July 22, 2025 16:46

github-actions Bot locked and limited conversation to collaborators Jul 22, 2025

metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: balance stuck in loading state.#17372

fix: balance stuck in loading state.#17372
darioAnongba merged 10 commits into
mainfrom
fix/balances-bitcoin

darioAnongba commented Jul 18, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot left a comment

Uh oh!

codecov-commenter commented Jul 22, 2025

Uh oh!

sonarqubecloud Bot commented Jul 22, 2025

Uh oh!

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


	for (const assetId of assetIds) {
	const { chainId } = parseCaipAssetType(assetId);
	const nativeAssetId =
	AVAILABLE_MULTICHAIN_NETWORK_CONFIGURATIONS[
	chainId as SupportedCaipChainId
	]?.nativeCurrency;

	const balance = balances[assetId] \|\| { amount: '0', unit: '' };

	// Safely handle undefined rate
	const rate = multichainAssetsRates?.[assetId]?.rate;
	const balanceInFiat =
	balance.amount && rate
	? new BigNumber(balance.amount).times(rate)
	: new BigNumber(0);
	fiatBalances[assetId] = balanceInFiat.toString();

	// If the asset is the native asset of the chain, set it as total native token balance
	// This assumes the account is always on the same chain (excludes testnets)
	if (assetId === nativeAssetId) {
	totalNativeTokenBalance = balance;
	}

Uh oh!

Conversation

darioAnongba commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Native Token Balance Overwrite Bug

Uh oh!

codecov-commenter commented Jul 22, 2025

Codecov Report

Uh oh!

sonarqubecloud Bot commented Jul 22, 2025

Quality Gate passed

Uh oh!

github-actions Bot commented Jul 22, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

darioAnongba commented Jul 18, 2025 •

edited

Loading

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading