fix: Fix gas inputs to handle comma instead of dot by OGPoyraz · Pull Request #17360 · MetaMask/metamask-mobile

OGPoyraz · 2025-07-18T10:08:05Z

Description

This PR aims to fix gas inputs to replace comma , input to dot .

Changelog

CHANGELOG entry: Fixed a bug on comma inputs on gas text boxes.

Related issues

Fixes: #17195

Manual testing steps

Trigger any transaction
Try changing gas values with decimal value - use a comma separator
It should immediately replace with dot and shouldn't throw error.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-18T10:08:48Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 758ac7b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9b4430f1-a051-4706-9b8b-29bfe14d0599

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-07-21T12:07:11Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0ba6596
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d3da504-7773-410e-92c3-0d51847b3642

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-07-22T07:53:47Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ebe2fd3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da7a68f1-47ac-411f-b2c9-10e8ea7eeb81

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-07-23T07:02:38Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 515cb31
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/20303a12-09b2-4f65-b160-e1dd10aaf6bd

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor

Bug: Comma Parsing Error in Validation Functions

The validateValueIsPositive and validateGasLimitValueIsGreaterThanMinimum functions exhibit inconsistent validation behavior for comma-separated numerical inputs. Unlike other validation functions, they directly use parseFloat(value) instead of first normalizing the input with normalizeGasInput(). This causes parseFloat to incorrectly parse values (e.g., "0,5" as 0, "21,000" as 21), leading to erroneous validation results and undermining the PR's intent to handle comma inputs.

app/components/Views/confirmations/utils/validations/gas.ts#L99-L124

metamask-mobile/app/components/Views/confirmations/utils/validations/gas.ts

Lines 99 to 124 in 515cb31

    
           function validateValueIsPositive( 
        
             value: string, 
        
             field: string, 
        
           ): string | boolean { 
        
             if (parseFloat(value) > 0) { 
        
               return false; 
        
             } 
        
             if (parseFloat(value) === 0) { 
        
               return strings('transactions.gas_modal.no_zero_value', { 
        
                 field, 
        
               }); 
        
             } 
        
             return strings('transactions.gas_modal.negative_values_not_allowed'); 
        
           } 
        
           function validateGasLimitValueIsGreaterThanMinimum( 
        
             value: string, 
        
           ): string | boolean { 
        
             if (parseFloat(value) >= 21000) { 
        
               return false; 
        
             } 
        
             return strings('transactions.gas_modal.gas_limit_too_low'); 
        
           }

Fix in Cursor • Fix in Web

Bug: Comma Replacement Bug in Gas Input Normalization

The normalizeGasInput function incorrectly uses replace(',', '.'), which only replaces the first occurrence of a comma. This leaves subsequent commas in the input (e.g., "1,234,56" becomes "1.234,56"), resulting in an invalid number format. It should use replace(/,/g, '.') or replaceAll(',', '.') to replace all commas.

app/components/Views/confirmations/utils/gas.ts#L168-L171

metamask-mobile/app/components/Views/confirmations/utils/gas.ts

Lines 168 to 171 in 515cb31

    
           export function normalizeGasInput(value: string) { 
        
             return value.replace(',', '.'); 
        
           }

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-23T07:18:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
1 Security Hotspot
96.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Fix gas inputs to handle comma instead of dot

758ac7b

OGPoyraz requested a review from a team as a code owner July 18, 2025 10:08

OGPoyraz added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 18, 2025

metamaskbot added the team-confirmations Push issues to confirmations team label Jul 18, 2025

OGPoyraz added Run Smoke E2E and removed team-confirmations Push issues to confirmations team labels Jul 18, 2025

This comment was marked as outdated.

Sign in to view

matthewwalsh0 requested changes Jul 18, 2025

View reviewed changes

Comment thread app/components/Views/confirmations/components/gas/gas-price-input/gas-price-input.tsx Outdated

OGPoyraz added 2 commits July 18, 2025 14:37

Update

e7a27f6

Update

a27503b

This comment was marked as outdated.

Sign in to view

Fix tests

e70c322

OGPoyraz added Run Smoke E2E and removed Run Smoke E2E labels Jul 21, 2025

This comment was marked as outdated.

Sign in to view

metamaskbot added the bitrise-result-ready label Jul 21, 2025

github-actions Bot removed the bitrise-result-ready label Jul 21, 2025

Update

305f8b6

OGPoyraz force-pushed the ogp/17195 branch from 0ba6596 to 305f8b6 Compare July 22, 2025 07:43

OGPoyraz added 2 commits July 22, 2025 10:44

Update

58cc1ca

Update

1b9c2f4

This comment was marked as outdated.

Sign in to view

OGPoyraz added 2 commits July 22, 2025 10:50

Update

bcacc16

Fix lint

9708e12

OGPoyraz force-pushed the ogp/17195 branch from 4076ad9 to 9708e12 Compare July 22, 2025 07:53

Merge branch 'main' into ogp/17195

ebe2fd3

OGPoyraz added Run Smoke E2E and removed Run Smoke E2E labels Jul 22, 2025

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into ogp/17195

515cb31

OGPoyraz added Run Smoke E2E and removed Run Smoke E2E labels Jul 23, 2025

cursor Bot reviewed Jul 23, 2025

View reviewed changes

OGPoyraz added Run Smoke E2E team-confirmations Push issues to confirmations team and removed Run Smoke E2E labels Jul 23, 2025

metamaskbot added the bitrise-result-ready label Jul 23, 2025

github-actions Bot removed the bitrise-result-ready label Jul 23, 2025

matthewwalsh0 approved these changes Jul 23, 2025

View reviewed changes

OGPoyraz enabled auto-merge July 23, 2025 09:48

OGPoyraz added this pull request to the merge queue Jul 23, 2025

Merged via the queue into main with commit 6955a8d Jul 23, 2025
63 of 72 checks passed

OGPoyraz deleted the ogp/17195 branch July 23, 2025 10:10

github-actions Bot locked and limited conversation to collaborators Jul 23, 2025

metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Fix gas inputs to handle comma instead of dot#17360

fix: Fix gas inputs to handle comma instead of dot#17360
OGPoyraz merged 11 commits into
mainfrom
ogp/17195

OGPoyraz commented Jul 18, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 18, 2025 •

edited by metamaskbot

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 21, 2025 •

edited by metamaskbot

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 23, 2025 •

edited by metamaskbot

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

sonarqubecloud Bot commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


	function validateValueIsPositive(
	value: string,
	field: string,
	): string \| boolean {
	if (parseFloat(value) > 0) {
	return false;
	}

	if (parseFloat(value) === 0) {
	return strings('transactions.gas_modal.no_zero_value', {
	field,
	});
	}

	return strings('transactions.gas_modal.negative_values_not_allowed');
	}

	function validateGasLimitValueIsGreaterThanMinimum(
	value: string,
	): string \| boolean {
	if (parseFloat(value) >= 21000) {
	return false;
	}
	return strings('transactions.gas_modal.gas_limit_too_low');
	}


	export function normalizeGasInput(value: string) {
	return value.replace(',', '.');
	}

Uh oh!

Conversation

OGPoyraz commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 18, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 21, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 22, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 23, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Comma Parsing Error in Validation Functions

Bug: Comma Replacement Bug in Gas Input Normalization

Uh oh!

sonarqubecloud Bot commented Jul 23, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OGPoyraz commented Jul 18, 2025 •

edited

Loading

github-actions Bot commented Jul 18, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 21, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 22, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 23, 2025 •

edited by metamaskbot

Loading