Skip to content

fix: crowdin bot#17350

Merged
sethkfman merged 5 commits into
mainfrom
chore/fix-crowdin-bot
Jul 22, 2025
Merged

fix: crowdin bot#17350
sethkfman merged 5 commits into
mainfrom
chore/fix-crowdin-bot

Conversation

@tommasini

@tommasini tommasini commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue where the Crowdin Action workflow was not triggering GitHub CI steps after making translation commits.

Problem:
The Crowdin Action workflow was configured with a token mismatch - the checkout step used the default GITHUB_TOKEN (with limited permissions), while the Crowdin action itself used METAMASKBOT_CROWDIN_TOKEN (PAT). This inconsistency prevented the workflow from having the necessary permissions to trigger subsequent CI workflows.

Solution:

  • Removed the permissions section that was limiting the workflow to default token permissions
  • Added the PAT (METAMASKBOT_CROWDIN_TOKEN) to the checkout step so both checkout and Crowdin action operations use the same token
  • This ensures consistent authentication and proper permissions for triggering other workflows

The fix follows the same pattern used in the MetaMask Extension repository's Crowdin workflow.

Changelog

CHANGELOG entry: null

Related issues

Fixes: GitHub CI steps not triggering after Crowdin Action commits

Manual testing steps

  1. Monitor the Crowdin Action workflow runs in the Actions tab
  2. Verify that when the Crowdin Action makes translation commits, the CI workflow is triggered
  3. Check that the bot commits are properly attributed to metamaskbot
  4. Confirm that translation updates flow through the normal CI pipeline

Screenshots/Recordings

Before

  • Crowdin Action would run but CI workflows would not be triggered by the resulting commits
  • Token permission mismatch between checkout and action steps

After

  • Crowdin Action commits should now properly trigger CI workflows
  • Consistent token usage throughout the workflow

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Jul 17, 2025
@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed labels Jul 17, 2025
sethkfman
sethkfman previously approved these changes Jul 17, 2025

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman enabled auto-merge July 17, 2025 20:51
Comment thread .github/workflows/crowdin_action.yml
Co-authored-by: Mark Stacey <markjstacey@gmail.com>

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

Copy link
Copy Markdown

@sethkfman sethkfman added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit f273db2 Jul 22, 2025
44 checks passed
@sethkfman sethkfman deleted the chore/fix-crowdin-bot branch July 22, 2025 22:41
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants