fix: crowdin bot#17350
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Jul 17, 2025
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes an issue where the Crowdin Action workflow was not triggering GitHub CI steps after making translation commits.
Problem:
The Crowdin Action workflow was configured with a token mismatch - the checkout step used the default
GITHUB_TOKEN(with limited permissions), while the Crowdin action itself usedMETAMASKBOT_CROWDIN_TOKEN(PAT). This inconsistency prevented the workflow from having the necessary permissions to trigger subsequent CI workflows.Solution:
permissionssection that was limiting the workflow to default token permissionsMETAMASKBOT_CROWDIN_TOKEN) to the checkout step so both checkout and Crowdin action operations use the same tokenThe fix follows the same pattern used in the MetaMask Extension repository's Crowdin workflow.
Changelog
CHANGELOG entry: null
Related issues
Fixes: GitHub CI steps not triggering after Crowdin Action commits
Manual testing steps
metamaskbotScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist