fix: Design QA Bugs 4 cp-7.52.0 by smgv · Pull Request #17335 · MetaMask/metamask-mobile

smgv · 2025-07-17T16:49:52Z

Description

Revalidate below GitHub issues (@LeVinhGithub ):

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-07-17.at.8.30.36.PM.mov

Screen.Recording.2025-07-17.at.9.04.55.PM.mov

Screen.Recording.2025-07-17.at.10.12.47.PM.mov

Simulator Screenshot - iPhone 16 Pro - 2025-07-21 at 18 36 14

Simulator Screenshot - iPhone 16 Pro - 2025-07-21 at 18 43 32

Simulator Screenshot - iPhone 16 Pro - 2025-07-21 at 18 45 47

Simulator Screenshot - iPhone 16 Pro - 2025-07-21 at 19 04 56

Revalidate Issues:

Issuse 1 & 2:

Screen.Recording.2025-07-21.at.3.29.02.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…wards after a few times

github-actions · 2025-07-17T16:50:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-07-17T16:50:20Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 17ae548
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1adb719d-b334-434f-948d-daeee0e79968

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-07-18T05:31:20Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: efb1aa9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83a179dd-0d7c-47b1-8e9b-635f9c83ae16

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-07-21T15:53:49Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 727d60f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f90a0d2-80fe-4e74-a9ab-ea5d27c0340a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor

Bug: Error Persistence During Login Attempts

The setError(null) call was moved from the beginning of the onLogin function to only occur after successful authentication. This prevents previous error messages from being cleared at the start of new login attempts, causing them to persist and be visible during the loading state, which creates a confusing user experience.

app/components/Views/Login/index.tsx#L506-L535

metamask-mobile/app/components/Views/Login/index.tsx

Lines 506 to 535 in 8cea658

    
           setLoading(true); 
        
           await performAuthentication(); 
        
           Keyboard.dismiss(); 
        
           if (oauthLoginSuccess) { 
        
             track(MetaMetricsEvents.REHYDRATION_COMPLETED, { 
        
               account_type: 'social', 
        
               biometrics: biometryChoice, 
        
               failed_attempts: rehydrationFailedAttempts, 
        
             }); 
        
           } 
        
           Keyboard.dismiss(); 
        
           if (passwordLoginAttemptTraceCtxRef.current) { 
        
             endTrace({ name: TraceName.OnboardingPasswordLoginAttempt }); 
        
             passwordLoginAttemptTraceCtxRef.current = null; 
        
           } 
        
           endTrace({ name: TraceName.OnboardingExistingSocialLogin }); 
        
           endTrace({ name: TraceName.OnboardingJourneyOverall }); 
        
           await checkMetricsUISeen(); 
        
           // Only way to land back on Login is to log out, which clears credentials (meaning we should not show biometric button) 
        
           setPassword(''); 
        
           setLoading(false); 
        
           setHasBiometricCredentials(false); 
        
           setError(null);

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-23T05:51:05Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

smgv added 6 commits July 17, 2025 20:31

fix: Copy is wrong for password for social login

ed9391d

fix: Copy on main screen is wrong for SRP

0c070dc

fix: Apple icon should be white in dark mode

205e9ca

fix: Link text copy is wrong on rehydration

244787b

fix: When clicking on unlock a few times, it seems to be glitching up…

58eabbc

…wards after a few times

fix: Can we shift fox closer to the center of the screen

5e1c639

smgv requested a review from chaitanyapotti July 17, 2025 16:49

smgv self-assigned this Jul 17, 2025

smgv requested review from a team as code owners July 17, 2025 16:49

smgv added area-onboarding needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E team-onboarding Onboarding team labels Jul 17, 2025

Merge branch 'main' into fix/design-ui-bugs

17ae548

This comment was marked as outdated.

Sign in to view

smgv changed the title ~~Fix/design UI bugs~~ fix: Design QA Bugs 4 Jul 17, 2025

metamaskbot added the bitrise-result-ready label Jul 17, 2025

github-actions Bot removed the bitrise-result-ready label Jul 17, 2025

smgv added 3 commits July 18, 2025 10:32

fix: SRP Import Section Color

6487304

Merge branch 'main' into fix/design-ui-bugs

b024f4f

Merge branch 'main' into fix/design-ui-bugs

efb1aa9

smgv added Run Smoke E2E and removed Run Smoke E2E labels Jul 18, 2025

This comment was marked as outdated.

Sign in to view

fix: responsive changes

76f0324

This comment was marked as outdated.

Sign in to view

hieu-w added Run Smoke E2E and removed Run Smoke E2E labels Jul 21, 2025

metamaskbot added the bitrise-result-ready label Jul 21, 2025

github-actions Bot removed the bitrise-result-ready label Jul 21, 2025

chaitanyapotti changed the title ~~fix: Design QA Bugs 4~~ fix: Design QA Bugs 4 cp-7.52.0 Jul 22, 2025

chaitanyapotti approved these changes Jul 22, 2025

View reviewed changes

chaitanyapotti added this pull request to the merge queue Jul 22, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025

chaitanyapotti added this pull request to the merge queue Jul 22, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025

chaitanyapotti added this pull request to the merge queue Jul 22, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025

Merge branch 'main' into fix/design-ui-bugs

236332a

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into fix/design-ui-bugs

8cea658

cursor Bot reviewed Jul 23, 2025

View reviewed changes

chaitanyapotti added this pull request to the merge queue Jul 23, 2025

Merged via the queue into main with commit 039d041 Jul 23, 2025
44 checks passed

chaitanyapotti deleted the fix/design-ui-bugs branch July 23, 2025 07:21

github-actions Bot locked and limited conversation to collaborators Jul 23, 2025

metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 23, 2025

metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Design QA Bugs 4 cp-7.52.0#17335

fix: Design QA Bugs 4 cp-7.52.0#17335
chaitanyapotti merged 20 commits into
mainfrom
fix/design-ui-bugs

smgv commented Jul 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 17, 2025

Uh oh!

github-actions Bot commented Jul 17, 2025 •

edited by metamaskbot

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 18, 2025 •

edited by metamaskbot

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 21, 2025 •

edited by metamaskbot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot left a comment

Uh oh!

sonarqubecloud Bot commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


	setLoading(true);

	await performAuthentication();
	Keyboard.dismiss();

	if (oauthLoginSuccess) {
	track(MetaMetricsEvents.REHYDRATION_COMPLETED, {
	account_type: 'social',
	biometrics: biometryChoice,
	failed_attempts: rehydrationFailedAttempts,
	});
	}

	Keyboard.dismiss();

	if (passwordLoginAttemptTraceCtxRef.current) {
	endTrace({ name: TraceName.OnboardingPasswordLoginAttempt });
	passwordLoginAttemptTraceCtxRef.current = null;
	}
	endTrace({ name: TraceName.OnboardingExistingSocialLogin });
	endTrace({ name: TraceName.OnboardingJourneyOverall });

	await checkMetricsUISeen();

	// Only way to land back on Login is to log out, which clears credentials (meaning we should not show biometric button)
	setPassword('');
	setLoading(false);
	setHasBiometricCredentials(false);
	setError(null);

Uh oh!

Conversation

smgv commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 17, 2025

Uh oh!

github-actions Bot commented Jul 17, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 18, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 21, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Error Persistence During Login Attempts

Uh oh!

sonarqubecloud Bot commented Jul 23, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

smgv commented Jul 17, 2025 •

edited

Loading

github-actions Bot commented Jul 17, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 18, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 21, 2025 •

edited by metamaskbot

Loading