Skip to content

fix: Remove setting for incoming transaction toggle#17320

Merged
jpuri merged 13 commits into
mainfrom
cleanup_incoming_trxn_setting
Jul 22, 2025
Merged

fix: Remove setting for incoming transaction toggle#17320
jpuri merged 13 commits into
mainfrom
cleanup_incoming_trxn_setting

Conversation

@jpuri

@jpuri jpuri commented Jul 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Remove setting for incoming transaction toggle, as it is no longer used by TransactionController.

Changelog

CHANGELOG entry:

Related issues

Fixes: #17091

Manual testing steps

  1. Incoming transaction should work as expect if privacy mode is disabled

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 17, 2025
@jpuri jpuri marked this pull request as ready for review July 17, 2025 13:11
@jpuri jpuri requested review from a team as code owners July 17, 2025 13:11
@github-actions

github-actions Bot commented Jul 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3834798
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60f0913c-cb8b-44db-9e3e-26091825c7e0

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri enabled auto-merge July 17, 2025 13:13
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f4797c7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17d2c2de-a53d-4705-8f4a-f10f244fc86f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Jul 17, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vinistevam
vinistevam reviewed Jul 21, 2025
View reviewed changes
Comment thread e2e/specs/wallet/incoming-transactions.spec.js
@jpuri jpuri added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 205fff0 Jul 22, 2025
52 of 58 checks passed
@jpuri jpuri deleted the cleanup_incoming_trxn_setting branch July 22, 2025 15:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vinistevam vinistevam vinistevam left review comments

@cursor cursor[bot] cursor[bot] left review comments

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

Assignees

No one assigned

Labels

release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Incoming transactions toggles not required

5 participants

@jpuri @matthewwalsh0 @NidhiKJha @vinistevam @metamaskbot