Skip to content

chore: Adding e2e for switch acount action#17119

Merged
jpuri merged 5 commits into
mainfrom
7702_e2e
Jul 21, 2025
Merged

chore: Adding e2e for switch acount action#17119
jpuri merged 5 commits into
mainfrom
7702_e2e

Conversation

@jpuri

@jpuri jpuri commented Jul 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adding e2e for switch account and batched confirmations.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5360
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5361

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 11, 2025
@socket-security

socket-security Bot commented Jul 11, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​test-dapp@​9.2.0 ⏵ 9.4.097 -11008993 +4100

View full report

@jpuri jpuri changed the title Adding e2e for switch acount action chore: Adding e2e for switch acount action Jul 11, 2025
@jpuri jpuri marked this pull request as ready for review July 11, 2025 16:38
@jpuri jpuri requested review from a team as code owners July 11, 2025 16:38
@github-actions

github-actions Bot commented Jul 18, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 585f573
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a6485c99-28ab-4a7a-be1d-7ccc2d63dd34

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e63762b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/164528e6-6b5c-4d70-a4ad-5eaead8dfc66

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri enabled auto-merge July 21, 2025 07:41
@sonarqubecloud

sonarqubecloud Bot commented Jul 21, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vinnyhoward
vinnyhoward approved these changes Jul 21, 2025
View reviewed changes

@vinnyhoward vinnyhoward left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpuri jpuri added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit 6d3641a Jul 21, 2025
68 of 86 checks passed
@jpuri jpuri deleted the 7702_e2e branch July 21, 2025 19:25
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 21, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpuri @vinnyhoward @vinistevam @metamaskbot