feat: Perps list display by gambinish · Pull Request #17078 · MetaMask/metamask-mobile

gambinish · 2025-07-10T17:48:29Z

Description

Based of of initial draft here: #17070 and rebased to final feature branch for perps.

This adds a view to explore Perps Markets in a list form, including a search bar to filter results by.

Changelog

CHANGELOG entry: Add Perpetual Markets List

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Screen.Recording.2025-07-10.at.10.47.44.AM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Add a new "Perps" wallet action to validate @deeeed/hyperliquid-node20 SDK integration. Implements TAT-1202 with minimal changes following MetaMask design patterns. Key features: - Feature flag controlled via RemoteFeatureFlagController ("perps-enabled") - Test screen with SDK connectivity validation (HTTP, WebSocket, asset listing) - Proper polyfills for WebSocket support in React Native - Team ownership via CODEOWNERS 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

…orePatterns in jest.config.js

- Add comprehensive PerpsController with protocol-agnostic API - Implement HyperLiquidProvider with proper WebSocket lifecycle management - Add navigation monitoring hook for automatic connect/disconnect - Integrate WebSocket cleanup when leaving Perps routes - Add deposit flow views with real MetaMask pricing integration - Fix TypeScript errors and optimize React hooks for performance - Implement proper asyncDispose pattern for WebSocket connections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

…-funds

…dMock.js

…ve provier. Generalize market data naming conventions

…iquidProvider

nickewansmith

LGTM

Addressed comments

cursor

Bug: Incorrect Indexing in Market Data Transformation

The transformMarketData function incorrectly uses universe.indexOf(asset) to find the corresponding assetCtx within a map iteration. This is inefficient and potentially unreliable due to reliance on object reference equality or the presence of duplicate assets. Since universe and assetCtxs are parallel arrays, the index parameter from the map function should be used instead.

app/components/UI/Perps/utils/marketDataTransform.ts#L26-L35

metamask-mobile/app/components/UI/Perps/utils/marketDataTransform.ts

Lines 26 to 35 in 87f6641

    
           return universe.map((asset) => { 
        
             const symbol = asset.name; 
        
             const currentPrice = parseFloat(allMids[symbol]); 
        
             // Find matching asset context for additional data 
        
             // Note: assetCtxs array from metaAndAssetCtxs might have different structure 
        
             // The array index should correspond to the universe array index 
        
             const assetCtx = assetCtxs[universe.indexOf(asset)];

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-22T13:17:19Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

abretonc7s and others added 30 commits July 8, 2025 16:50

cleanup

7d957cd

cleanup

9e3b545

feat: perp wallet action cleanup

cf52e59

feat: add @noble/secp256k1|@deeeed/hyperliquid-node20 to transformIgn…

a408f99

…orePatterns in jest.config.js

feat: added perps tests for WalletActions

a1f9aa8

wip

2c59c07

navigation

15710e3

deposit

9e31e4a

wip

8437b4b

validation flows

e172d90

lockfile deps

cc90266

wip

0b1cba5

Merge remote-tracking branch 'origin/main' into feat/tat-1202-deposit…

1fbbebe

…-funds

pr comments

8daea0b

i18n

5ac6c53

fix: correct routes

d02ed2c

perpscontroller and remove persistence

2251503

cleanup

02b8aae

Merge remote-tracking branch 'origin/main' into feat/tat-1202-deposit…

9a697f6

…-funds

basic tests

1fef33a

more unit tests

bb5aa29

more unit tests

e9439ba

more unti tests

ea17f9e

more unit tests

6028bc7

feat: updated jest.config.js to support deep imports

dbee49f

feat: added missing actionSorter and signL1Action mocks to hyperliqui…

73136fb

…dMock.js

feat: fixed App.test.tsx test suite

bd976a6

feat: added ExpoHaptics to Podfile.lock

b5452d4

abretonc7s previously requested changes Jul 18, 2025

View reviewed changes

nickewansmith reviewed Jul 18, 2025

View reviewed changes

Comment thread app/components/UI/Perps/Views/PerpsView.tsx Outdated

gambinish added 6 commits July 18, 2025 14:03

chore: Allow for optional protocol id for filtering, fallback to acti…

bad4a1d

…ve provier. Generalize market data naming conventions

fix: Dont hardcode navigation routes

c85a52c

fix: PerpsMarketData interface

c7c06b3

chore: Create separate transformMarketData private function in Hyperl…

c0ad3e4

…iquidProvider

fix: Use Devlogger

ee1a80c

chore: Consolidate transformMarketData into utility

c972536

This comment was marked as outdated.

Sign in to view

fix: Add consts for buttons

08c9d2f

This comment was marked as outdated.

Sign in to view

fix: yarn lint tsc

d21e551

This comment was marked as outdated.

Sign in to view

chore: Update unit test

46baec2

gambinish requested review from abretonc7s and nickewansmith July 18, 2025 22:50

nickewansmith approved these changes Jul 21, 2025

View reviewed changes

Merge branch 'main' into feat/perps-list-display

e6db6a0

gambinish enabled auto-merge July 21, 2025 20:43

gambinish removed the request for review from abretonc7s July 21, 2025 20:43

Merge branch 'main' into feat/perps-list-display

87f6641

cursor Bot reviewed Jul 22, 2025

View reviewed changes

gambinish added this pull request to the merge queue Jul 22, 2025

Merged via the queue into main with commit 4f751a4 Jul 22, 2025
43 of 44 checks passed

gambinish deleted the feat/perps-list-display branch July 22, 2025 13:38

github-actions Bot locked and limited conversation to collaborators Jul 22, 2025

metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Perps list display#17078

feat: Perps list display#17078
gambinish merged 100 commits into
mainfrom
feat/perps-list-display

gambinish commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nickewansmith left a comment

Uh oh!

cursor Bot left a comment

Uh oh!

sonarqubecloud Bot commented Jul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


	return universe.map((asset) => {
	const symbol = asset.name;
	const currentPrice = parseFloat(allMids[symbol]);

	// Find matching asset context for additional data
	// Note: assetCtxs array from metaAndAssetCtxs might have different structure
	// The array index should correspond to the universe array index
	const assetCtx = assetCtxs[universe.indexOf(asset)];

Uh oh!

Conversation

gambinish commented Jul 10, 2025

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nickewansmith left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Incorrect Indexing in Market Data Transformation

Uh oh!

sonarqubecloud Bot commented Jul 22, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants