test: fix encrypt password synchronization by chrisleewilcox · Pull Request #17048 · MetaMask/metamask-mobile

chrisleewilcox · 2025-07-10T00:13:07Z

Description

This PR fixes synchronization issues in AES encryption end-to-end tests and improves test infrastructure by adding proper selectors and reorganizing test categorization.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ponents

…e SmokeAccounts tag - Commented out several existing workflows in the Bitrise configuration for the e2e testing stages. - Added new workflows for `run_tag_smoke_accounts_ios` and `run_tag_smoke_accounts_android`. - Updated AES encryption test files to replace `SmokeNetworkExpansion` with `SmokeAccounts` for better categorization of tests.

github-actions · 2025-07-10T00:13:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-07-10T00:13:53Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8c16ac4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3463df68-ee5e-48d2-9e5a-ae2f7ab58813

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

- Commented out the visibility check for the response text in the AES encryption test to streamline the test flow.

- Replaced instances of SmokeNetworkExpansion with SmokeAccounts in error boundary, import wallet, and reveal secret recovery phrase test files for improved test categorization.

github-actions · 2025-07-10T01:41:15Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5c391f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/482d25b0-6652-4e26-b0d3-8616ec023716

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

- Restored previously commented-out workflows in the Bitrise configuration for various e2e testing stages, enhancing the testing coverage for both iOS and Android platforms.

github-actions · 2025-07-10T02:15:04Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d000d99
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe3a1485-94c9-4af1-ad6e-116d39774286

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor

Bug: Duplicate Test IDs in Form Components

Multiple TestForm components are assigned the same responseTextTestId (responseText, which resolves to 'response-text'). This creates non-unique test IDs for response text elements on the same screen, violating test automation best practices and hindering reliable element targeting in automated tests.

app/components/Views/AesCryptoTestForm/AesCryptoTestForm.tsx#L169-L260

metamask-mobile/app/components/Views/AesCryptoTestForm/AesCryptoTestForm.tsx

Lines 169 to 260 in d000d99

    
             responseTestId={aesCryptoFormResponses.saltResponse} 
        
             responseTextTestId={responseText} 
        
             styles={{ ...styles }} 
        
           /> 
        
           <TestForm 
        
             title={strings('aes_crypto_test_form.generate_encryption_key')} 
        
             buttonLabel={strings('aes_crypto_test_form.generate')} 
        
             textFields={[ 
        
               { 
        
                 placeholder: strings('aes_crypto_test_form.password'), 
        
                 testId: aesCryptoFormInputs.passwordInput, 
        
               }, 
        
               { 
        
                 placeholder: strings('aes_crypto_test_form.salt'), 
        
                 testId: aesCryptoFormInputs.saltInputForEncryptionKey, 
        
               }, 
        
             ]} 
        
             callback={generateEncryptionKey} 
        
             callbackTestId={aesCryptoFormButtons.generateEncryptionKeyButton} 
        
             responseTestId={aesCryptoFormResponses.generateEncryptionKeyResponse} 
        
             responseTextTestId={responseText} 
        
             styles={{ ...styles }} 
        
           /> 
        
           <TestForm 
        
             title={strings('aes_crypto_test_form.encrypt_with_key')} 
        
             buttonLabel={strings('aes_crypto_test_form.encrypt')} 
        
             textFields={[ 
        
               { 
        
                 placeholder: strings('aes_crypto_test_form.encryption_key'), 
        
                 testId: 
        
                   aesCryptoFormInputs.encryptionKeyInputForEncryptionWithKey, 
        
               }, 
        
               { 
        
                 placeholder: strings('aes_crypto_test_form.data'), 
        
                 testId: aesCryptoFormInputs.dataInputForEncryptionWithKey, 
        
               }, 
        
             ]} 
        
             callback={encryptWithKey} 
        
             callbackTestId={aesCryptoFormButtons.encryptWithKeyButton} 
        
             responseTestId={aesCryptoFormResponses.encryptionWithKeyResponse} 
        
             responseTextTestId={responseText} 
        
             styles={{ ...styles }} 
        
           /> 
        
           <TestForm 
        
             title={strings('aes_crypto_test_form.decrypt_with_key')} 
        
             buttonLabel={strings('aes_crypto_test_form.decrypt')} 
        
             textFields={[ 
        
               { 
        
                 placeholder: 'Encryption Key', 
        
                 testId: 
        
                   aesCryptoFormInputs.encryptionKeyInputForDecryptionWithKey, 
        
               }, 
        
             ]} 
        
             callback={decryptWithKey} 
        
             callbackTestId={aesCryptoFormButtons.decryptWithKeyButton} 
        
             responseTestId={aesCryptoFormResponses.decryptionWithKeyResponse} 
        
             responseTextTestId={responseText} 
        
             styles={{ ...styles }} 
        
           /> 
        
           <TestForm 
        
             title={strings('aes_crypto_test_form.encrypt')} 
        
             buttonLabel={strings('aes_crypto_test_form.encrypt')} 
        
             textFields={[ 
        
               { 
        
                 placeholder: strings('aes_crypto_test_form.data'), 
        
                 testId: aesCryptoFormInputs.dataInputForEncryption, 
        
               }, 
        
               { 
        
                 placeholder: strings('aes_crypto_test_form.password'), 
        
                 testId: aesCryptoFormInputs.passwordInputForEncryption, 
        
               }, 
        
             ]} 
        
             callback={encrypt} 
        
             callbackTestId={aesCryptoFormButtons.encryptButton} 
        
             responseTestId={aesCryptoFormResponses.encryptionResponse} 
        
             responseTextTestId={responseText} 
        
             styles={{ ...styles }} 
        
           /> 
        
           <TestForm 
        
             title={strings('aes_crypto_test_form.decrypt')} 
        
             buttonLabel={strings('aes_crypto_test_form.decrypt')} 
        
             textFields={[ 
        
               { 
        
                 placeholder: strings('aes_crypto_test_form.password'), 
        
                 testId: aesCryptoFormInputs.passwordInputForDecryption, 
        
               }, 
        
             ]} 
        
             callback={decrypt} 
        
             callbackTestId={aesCryptoFormButtons.decryptButton} 
        
             responseTestId={aesCryptoFormResponses.decryptionResponse} 
        
             responseTextTestId={responseText} 
        
             styles={{ ...styles }}

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-10T02:28:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chrisleewilcox added 2 commits July 9, 2025 16:42

test: Add response text handling to AesCryptoTestForm and related com…

3a8b239

…ponents

metamaskbot added the team-qa QA team label Jul 10, 2025

chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Jul 10, 2025

fix: Remove unnecessary visibility check in AES encryption test

004a9d1

- Commented out the visibility check for the response text in the AES encryption test to streamline the test flow.

metamaskbot added the bitrise-result-ready label Jul 10, 2025

github-actions Bot removed the bitrise-result-ready label Jul 10, 2025

refactor: Update test descriptions to use SmokeAccounts tag

5c391f6

- Replaced instances of SmokeNetworkExpansion with SmokeAccounts in error boundary, import wallet, and reveal secret recovery phrase test files for improved test categorization.

chrisleewilcox added Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

metamaskbot added the bitrise-result-ready label Jul 10, 2025

github-actions Bot removed the bitrise-result-ready label Jul 10, 2025

chore: Un-comment Bitrise workflows for e2e testing stages

d000d99

- Restored previously commented-out workflows in the Bitrise configuration for various e2e testing stages, enhancing the testing coverage for both iOS and Android platforms.

chrisleewilcox marked this pull request as ready for review July 10, 2025 02:14

chrisleewilcox requested a review from a team July 10, 2025 02:14

chrisleewilcox added Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

cursor Bot reviewed Jul 10, 2025

View reviewed changes

cortisiko reviewed Jul 10, 2025

View reviewed changes

Comment thread e2e/selectors/Settings/AesCrypto.selectors.ts

cortisiko approved these changes Jul 10, 2025

View reviewed changes

chrisleewilcox enabled auto-merge July 10, 2025 02:38

metamaskbot added the bitrise-result-ready label Jul 10, 2025

github-actions Bot removed the bitrise-result-ready label Jul 10, 2025

chrisleewilcox added this pull request to the merge queue Jul 10, 2025

Merged via the queue into main with commit 504a50f Jul 10, 2025
63 of 65 checks passed

chrisleewilcox deleted the detox-add-encrypt-password-assert branch July 10, 2025 03:44

github-actions Bot locked and limited conversation to collaborators Jul 10, 2025

metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: fix encrypt password synchronization#17048

test: fix encrypt password synchronization#17048
chrisleewilcox merged 5 commits into
mainfrom
detox-add-encrypt-password-assert

chrisleewilcox commented Jul 10, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	responseTestId={aesCryptoFormResponses.saltResponse}
	responseTextTestId={responseText}
	styles={{ ...styles }}
	/>
	<TestForm
	title={strings('aes_crypto_test_form.generate_encryption_key')}
	buttonLabel={strings('aes_crypto_test_form.generate')}
	textFields={[
	{
	placeholder: strings('aes_crypto_test_form.password'),
	testId: aesCryptoFormInputs.passwordInput,
	},
	{
	placeholder: strings('aes_crypto_test_form.salt'),
	testId: aesCryptoFormInputs.saltInputForEncryptionKey,
	},
	]}
	callback={generateEncryptionKey}
	callbackTestId={aesCryptoFormButtons.generateEncryptionKeyButton}
	responseTestId={aesCryptoFormResponses.generateEncryptionKeyResponse}
	responseTextTestId={responseText}
	styles={{ ...styles }}
	/>
	<TestForm
	title={strings('aes_crypto_test_form.encrypt_with_key')}
	buttonLabel={strings('aes_crypto_test_form.encrypt')}
	textFields={[
	{
	placeholder: strings('aes_crypto_test_form.encryption_key'),
	testId:
	aesCryptoFormInputs.encryptionKeyInputForEncryptionWithKey,
	},
	{
	placeholder: strings('aes_crypto_test_form.data'),
	testId: aesCryptoFormInputs.dataInputForEncryptionWithKey,
	},
	]}
	callback={encryptWithKey}
	callbackTestId={aesCryptoFormButtons.encryptWithKeyButton}
	responseTestId={aesCryptoFormResponses.encryptionWithKeyResponse}
	responseTextTestId={responseText}
	styles={{ ...styles }}
	/>
	<TestForm
	title={strings('aes_crypto_test_form.decrypt_with_key')}
	buttonLabel={strings('aes_crypto_test_form.decrypt')}
	textFields={[
	{
	placeholder: 'Encryption Key',
	testId:
	aesCryptoFormInputs.encryptionKeyInputForDecryptionWithKey,
	},
	]}
	callback={decryptWithKey}
	callbackTestId={aesCryptoFormButtons.decryptWithKeyButton}
	responseTestId={aesCryptoFormResponses.decryptionWithKeyResponse}
	responseTextTestId={responseText}
	styles={{ ...styles }}
	/>
	<TestForm
	title={strings('aes_crypto_test_form.encrypt')}
	buttonLabel={strings('aes_crypto_test_form.encrypt')}
	textFields={[
	{
	placeholder: strings('aes_crypto_test_form.data'),
	testId: aesCryptoFormInputs.dataInputForEncryption,
	},
	{
	placeholder: strings('aes_crypto_test_form.password'),
	testId: aesCryptoFormInputs.passwordInputForEncryption,
	},
	]}
	callback={encrypt}
	callbackTestId={aesCryptoFormButtons.encryptButton}
	responseTestId={aesCryptoFormResponses.encryptionResponse}
	responseTextTestId={responseText}
	styles={{ ...styles }}
	/>
	<TestForm
	title={strings('aes_crypto_test_form.decrypt')}
	buttonLabel={strings('aes_crypto_test_form.decrypt')}
	textFields={[
	{
	placeholder: strings('aes_crypto_test_form.password'),
	testId: aesCryptoFormInputs.passwordInputForDecryption,
	},
	]}
	callback={decrypt}
	callbackTestId={aesCryptoFormButtons.decryptButton}
	responseTestId={aesCryptoFormResponses.decryptionResponse}
	responseTextTestId={responseText}
	styles={{ ...styles }}

Uh oh!

Conversation

chrisleewilcox commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions Bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions Bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Duplicate Test IDs in Form Components

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jul 10, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrisleewilcox commented Jul 10, 2025 •

edited

Loading

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading