Skip to content

chore: Add @MetaMask/perps codeowners to CODEOWNERS file#17041

Merged
gambinish merged 1 commit into
mainfrom
feat/perps-codeowners
Jul 9, 2025
Merged

chore: Add @MetaMask/perps codeowners to CODEOWNERS file#17041
gambinish merged 1 commit into
mainfrom
feat/perps-codeowners

Conversation

@gambinish

@gambinish gambinish commented Jul 9, 2025

Copy link
Copy Markdown
Member

Description

Adds newly formed Perps team to codeowned files within the Perps related directories.

Changelog

CHANGELOG entry: Add @MetaMask/perps codeowners to CODEOWNERS file

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish marked this pull request as ready for review July 9, 2025 19:49
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish requested a review from a team July 9, 2025 19:49
@gambinish gambinish added team-perps Perps team No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed and removed team-assets labels Jul 9, 2025
@Matt561 Matt561 requested a review from a team July 9, 2025 19:59
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gambinish gambinish enabled auto-merge July 9, 2025 20:08
@gambinish gambinish moved this to Needs dev review in PR review queue Jul 9, 2025
sethkfman
sethkfman approved these changes Jul 9, 2025
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gambinish gambinish added this pull request to the merge queue Jul 9, 2025
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 9, 2025
Merged via the queue into main with commit 6207258 Jul 9, 2025
68 of 71 checks passed
@gambinish gambinish deleted the feat/perps-codeowners branch July 9, 2025 20:50
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Matt561 Matt561 Matt561 approved these changes

+1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-perps Perps team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gambinish @sethkfman @Matt561 @metamaskbot