Skip to content

feat(deposit): webview modal component#17036

Merged
AxelGes merged 36 commits into
mainfrom
feat/bottom-sheet-webview
Jul 10, 2025
Merged

feat(deposit): webview modal component#17036
AxelGes merged 36 commits into
mainfrom
feat/bottom-sheet-webview

Conversation

@AxelGes

@AxelGes AxelGes commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This adds a WebView component inside a bottom sheet, so it slides up from the bottom for a more native feel in the deposit flow.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Screen.Recording.2025-07-03.at.1.55.09.AM.1.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@AxelGes AxelGes changed the title feat(deposit): bottom sheet webview feat(deposit): webview modal component Jul 9, 2025
@AxelGes AxelGes changed the title feat(deposit): webview modal component feat(deposit): BottomSheet webview modal Jul 9, 2025
@AxelGes AxelGes changed the title feat(deposit): BottomSheet webview modal feat(deposit): webview modal component Jul 9, 2025
@AxelGes AxelGes marked this pull request as ready for review July 9, 2025 16:52
@AxelGes AxelGes requested a review from a team as a code owner July 9, 2025 16:52
@AxelGes AxelGes added team-money-movement issues related to Money Movement features Run Smoke E2E labels Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3b80819
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9cdfb5e-1f59-479b-8d7e-8e591a0cb92e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov-commenter

codecov-commenter commented Jul 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.07595% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.14%. Comparing base (7f7778f) to head (836d7de).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...ponents/UI/Ramp/Deposit/hooks/useDepositRouting.ts 77.41% 3 Missing and 4 partials ⚠️
...Deposit/Views/Modals/WebviewModal/WebviewModal.tsx 84.61% 1 Missing and 1 partial ⚠️
...I/Ramp/Deposit/Views/EnterAddress/EnterAddress.tsx 75.00% 1 Missing ⚠️
...Ramp/Deposit/Views/KycProcessing/KycProcessing.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17036      +/-   ##
==========================================
+ Coverage   73.10%   73.14%   +0.03%     
==========================================
  Files        2749     2758       +9     
  Lines       59910    59935      +25     
  Branches     9470     9470              
==========================================
+ Hits        43800    43841      +41     
+ Misses      13364    13347      -17     
- Partials     2746     2747       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a2d919b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/15b7081b-810d-4430-ab7c-5855c13d861b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@AxelGes AxelGes added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 57c4a64 Jul 10, 2025
54 of 57 checks passed
@AxelGes AxelGes deleted the feat/bottom-sheet-webview branch July 10, 2025 02:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@wachunei wachunei wachunei approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AxelGes @codecov-commenter @wachunei @metamaskbot