Skip to content

refactor(deposit): send email throws true method#17034

Merged
wachunei merged 1 commit into
mainfrom
fix/deposit-enter-email-error
Jul 9, 2025
Merged

refactor(deposit): send email throws true method#17034
wachunei merged 1 commit into
mainfrom
fix/deposit-enter-email-error

Conversation

@wachunei

@wachunei wachunei commented Jul 9, 2025

Copy link
Copy Markdown
Member

Description

This PR refactors the send email method into the new promise style method call.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Jul 9, 2025
@wachunei wachunei added the QA Passed QA testing has been completed and passed label Jul 9, 2025
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wachunei wachunei marked this pull request as ready for review July 9, 2025 16:40
@wachunei wachunei requested a review from a team as a code owner July 9, 2025 16:40
@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aed1bac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/89f10a51-57a5-4318-9066-053bdb70fa3c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]
cursor Bot reviewed Jul 9, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Loading State Timing and Error Persistence Issues

The isLoading state is set prematurely before email validation, causing a brief, incorrect loading state when an invalid email is entered and no API call is made. Additionally, API errors are not cleared on subsequent submission attempts if the input text remains unchanged, leading to stale error messages persisting during the loading state.

app/components/UI/Ramp/Deposit/Views/EnterEmail/EnterEmail.tsx#L80-L103

metamask-mobile/app/components/UI/Ramp/Deposit/Views/EnterEmail/EnterEmail.tsx

Lines 80 to 103 in aed1bac

const handleSubmit = useCallback(async () => {
try {
setIsLoading(true);
if (validateEmail(email)) {
setValidationError(false);
await submitEmail();
navigation.navigate(
...createOtpCodeNavDetails({
quote,
email,
paymentMethodId,
cryptoCurrencyChainId,
}),
);
} else {
setValidationError(true);
}
} catch (e) {
setError(strings('deposit.enter_email.error'));
Logger.error(e as Error, 'Error submitting email');
} finally {
setIsLoading(false);
}

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@wachunei wachunei enabled auto-merge July 9, 2025 17:48
@wachunei wachunei added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 02a598b Jul 9, 2025
62 of 67 checks passed
@wachunei wachunei deleted the fix/deposit-enter-email-error branch July 9, 2025 18:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

+1 more reviewer

@AxelGes AxelGes AxelGes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wachunei @AxelGes @metamaskbot