Skip to content

refactor(deposit): only restrict created orders from new orders#17032

Merged
wachunei merged 1 commit into
mainfrom
refactor/deposit-created-order-redirect
Jul 9, 2025
Merged

refactor(deposit): only restrict created orders from new orders#17032
wachunei merged 1 commit into
mainfrom
refactor/deposit-created-order-redirect

Conversation

@wachunei

@wachunei wachunei commented Jul 9, 2025

Copy link
Copy Markdown
Member

Description

This PR allows pending orders to create new orders, only created orders is a blocker.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei requested a review from a team as a code owner July 9, 2025 15:06
@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Jul 9, 2025
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1beff5b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab3a574e-0801-4bd0-88bf-5c249a5c88ce

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 9, 2025
@wachunei wachunei added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 455bcc1 Jul 9, 2025
61 of 67 checks passed
@wachunei wachunei deleted the refactor/deposit-created-order-redirect branch July 9, 2025 19:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wachunei @georgeweiler @metamaskbot