Skip to content

feat: authenticate users if basic functionality is enabled#17027

Merged
mathieuartu merged 1 commit into
mainfrom
feat/authentication-basic-functionality
Jul 9, 2025
Merged

feat: authenticate users if basic functionality is enabled#17027
mathieuartu merged 1 commit into
mainfrom
feat/authentication-basic-functionality

Conversation

@mathieuartu

Copy link
Copy Markdown
Contributor

Description

This PR changes the authentication pre-requisites.
Having one auth related feature enabled is not required anymore to be automatically signed in. Only having basic functionality enabled suffices to automatically sign a user in.

Changelog

CHANGELOG entry:

Related issues

Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-169

Manual testing steps

  1. Onboarding with basic functionality (BF) off
  2. Verify (in proxyman or equivalent) that no call to the authentication API has been made
  3. Onboarding with BF on, but MetaMetrics, Notifications and Backup & Sync DISABLED
  4. Verify that successful calls to the authentication API have been made

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mathieuartu mathieuartu self-assigned this Jul 9, 2025
@mathieuartu mathieuartu added the team-identity-deprecated DEPRECATED: team no longer exists label Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mathieuartu mathieuartu added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E labels Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 65f0c99
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4a8fab08-3e1f-48fa-bb1d-e589fd16ed06

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

@mathieuartu mathieuartu added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 9, 2025
@mathieuartu mathieuartu marked this pull request as ready for review July 9, 2025 14:28
@mathieuartu mathieuartu requested a review from a team as a code owner July 9, 2025 14:28
@mathieuartu mathieuartu added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit eb680d3 Jul 9, 2025
69 of 77 checks passed
@mathieuartu mathieuartu deleted the feat/authentication-basic-functionality branch July 9, 2025 15:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-identity-deprecated DEPRECATED: team no longer exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants