fix: cp-7.51.0 remove InteractionManager blocking account selection callbacks in certain flows#17002
Merged
vinnyhoward merged 1 commit intoJul 9, 2025
Conversation
… due to blocking UI
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
|
Cal-L
approved these changes
Jul 8, 2025
Cal-L
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Would be good to know why the parent animation isn't resolving itself though. https://consensys.slack.com/archives/C02U025CVU4/p1752011324805149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Problem
The account picker was failing to select accounts in certain UI flows due to
InteractionManager.runAfterInteractions()blocking critical selection callbacks. When the UI was busy with animations or interactions, the callback queue would be deferred indefinitely, leaving users unable to switch accounts.Root Cause
The issue only occurred when
AccountSelectorwas rendered inline within active screens (such asBuildQuoteorSwapsAmountView) rather than as a modal (like theNavBar). In complex UI contexts with ongoing animations (keypad interactions, focus effects, loading states, etc), the interaction queue never clears, causingrunAfterInteractions()callbacks to wait indefinitely.Works:
Navbar→ ModalAccountSelector(interaction queue clears on navigation)Broken:
BuildQuote,SwapsAmountViewinlineAccountSelector(perpetual interaction queue from parent animations, not sure the EXACT animations causing the blockage)Solution
Removed the
InteractionManagerwrapper around the account selection logic inEvmAccountSelectorListImpact
InteractionManagerwas originally added for performance optimization unintentionally blocked user experienceChangelog
CHANGELOG entry: nullRelated issues
Fixes: #16942
Manual testing steps
Screenshots/Recordings
interaction-manager.mov
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist