Skip to content

test: add back notification e2e tests#16975

Merged
cmd-ob merged 16 commits into
mainfrom
test/add-back-notification-e2e-tests
Jul 10, 2025
Merged

test: add back notification e2e tests#16975
cmd-ob merged 16 commits into
mainfrom
test/add-back-notification-e2e-tests

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Jul 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

We quarantined the notif tests as they were flaking. Running the tests in isolation seem to pass.

Run 1
Run 2

Creating this PR to see if we can run the notification tests as part of the full smoke runs.

It is a little weird how these tests fail. Looking at previous runs where they failed, it looks as if the mock APIs are being called?
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8130d943-b958-4a71-a5fa-561040bcd5fb

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 5683fa4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82d5f3cf-eb8c-4aa0-8bd7-cc58c24df163

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented Jul 8, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 70a8e73
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da0b9c73-c8be-4479-aa5a-2cc3baa77927

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 8, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9841236
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bcfb3c60-b6a4-4f79-9a86-f95b78a6a7d6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 8, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4bc38ed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3735ee9c-81dd-460d-95e9-5538087d7cef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Prithpal-Sooriya
Prithpal-Sooriya commented Jul 8, 2025
View reviewed changes
Comment thread e2e/specs/notifications/utils/mock-notification-trigger-server.ts
Prithpal-Sooriya
Prithpal-Sooriya commented Jul 8, 2025
View reviewed changes
Comment thread e2e/specs/notifications/utils/mock-notification-trigger-server.ts
@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2f0341f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1278f80e-695e-49e7-bd78-a81674c7bc8b

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a263cc7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/64fdb9cc-26ee-4bbd-816e-43ac4516730c

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cmd-ob cmd-ob marked this pull request as ready for review July 10, 2025 07:14
@cmd-ob cmd-ob requested a review from a team as a code owner July 10, 2025 07:14
@github-actions

github-actions Bot commented Jul 10, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 04ca150
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c24af464-2c09-49e4-89e4-ef3b7c085fa2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]

This comment was marked as outdated.

Sign in to view

@cmd-ob cmd-ob added the QA Passed QA testing has been completed and passed label Jul 10, 2025
cmd-ob
cmd-ob previously approved these changes Jul 10, 2025
View reviewed changes
@cmd-ob cmd-ob requested review from cmd-ob and removed request for cmd-ob July 10, 2025 08:14
@cmd-ob cmd-ob enabled auto-merge July 10, 2025 08:29
@github-actions

github-actions Bot commented Jul 10, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8fe63c9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6a9b9f9-469c-498f-9f21-9fbd6592e083

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor[bot]
cursor Bot reviewed Jul 10, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Clean Up Debugging Statements

Remove temporary console.log debugging statements committed to the codebase.

e2e/specs/notifications/utils/mock-notification-trigger-server.ts#L68-L75

metamask-mobile/e2e/specs/notifications/utils/mock-notification-trigger-server.ts

Lines 68 to 75 in 8fe63c9

.thenCallback((request) => {
// eslint-disable-next-line no-console
console.log(
`Mocking ${request.method} request to: ${getDecodedProxiedURL(
request.url,
)}`,
);
return this.getConfig(request);

e2e/specs/notifications/utils/mock-notification-trigger-server.ts#L84-L91

metamask-mobile/e2e/specs/notifications/utils/mock-notification-trigger-server.ts

Lines 84 to 91 in 8fe63c9

.thenCallback((request) => {
// eslint-disable-next-line no-console
console.log(
`Mocking ${request.method} request to: ${getDecodedProxiedURL(
request.url,
)}`,
);
return this.updateConfig(request);

e2e/specs/notifications/utils/mocks.ts#L127-L134

metamask-mobile/e2e/specs/notifications/utils/mocks.ts

Lines 127 to 134 in 8fe63c9

.thenCallback((request) => {
// eslint-disable-next-line no-console
console.log(
`Mocking ${request.method} request to: ${getDecodedProxiedURL(
request.url,
)}`,
);
return {

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@codecov-commenter

codecov-commenter commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.14%. Comparing base (7e7823f) to head (8fe63c9).
Report is 47 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16975      +/-   ##
==========================================
+ Coverage   72.82%   73.14%   +0.31%     
==========================================
  Files        2742     2758      +16     
  Lines       59587    59948     +361     
  Branches     9409     9470      +61     
==========================================
+ Hits        43397    43851     +454     
+ Misses      13440    13350      -90     
+ Partials     2750     2747       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Jul 10, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cmd-ob cmd-ob added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 57016c1 Jul 10, 2025
55 of 58 checks passed
@cmd-ob cmd-ob deleted the test/add-back-notification-e2e-tests branch July 10, 2025 10:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@mathieuartu mathieuartu mathieuartu approved these changes

@cmd-ob cmd-ob cmd-ob left review comments

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Prithpal-Sooriya @codecov-commenter @mathieuartu @cmd-ob @metamaskbot