Skip to content

feat(deposit): error view#16947

Merged
wachunei merged 11 commits into
mainfrom
feat/deposit/error-view
Jul 9, 2025
Merged

feat(deposit): error view#16947
wachunei merged 11 commits into
mainfrom
feat/deposit/error-view

Conversation

@AxelGes

@AxelGes AxelGes commented Jul 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This adds an ErrorView component for the Deposit feature.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Jul 4, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@AxelGes AxelGes marked this pull request as ready for review July 9, 2025 00:56
@AxelGes AxelGes requested a review from a team as a code owner July 9, 2025 00:56
@AxelGes AxelGes removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@AxelGes AxelGes added Run Smoke E2E and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jul 9, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 85e5d90
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a3806bc-cfe3-483b-b6ce-56a6610c1485

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

georgeweiler
georgeweiler previously approved these changes Jul 9, 2025
View reviewed changes
@AxelGes AxelGes removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@AxelGes AxelGes added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 9, 2025
@codecov-commenter

codecov-commenter commented Jul 9, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.14%. Comparing base (0385ea0) to head (9dcb41e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../Views/DepositOrderDetails/DepositOrderDetails.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16947   +/-   ##
=======================================
  Coverage   73.13%   73.14%           
=======================================
  Files        2749     2751    +2     
  Lines       59917    59927   +10     
  Branches     9473     9477    +4     
=======================================
+ Hits        43819    43831   +12     
+ Misses      13349    13347    -2     
  Partials     2749     2749

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wachunei wachunei mentioned this pull request Jul 9, 2025
Merged
7 tasks
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 463eed1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/709fe753-6ab1-4879-be8a-95f482b4b810

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e8d02d1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b81a236-39cb-4f50-928f-66ddb2493320

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wachunei wachunei enabled auto-merge July 9, 2025 19:27
@wachunei wachunei added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit ad30960 Jul 9, 2025
51 of 53 checks passed
@wachunei wachunei deleted the feat/deposit/error-view branch July 9, 2025 19:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wachunei wachunei wachunei approved these changes

@georgeweiler georgeweiler georgeweiler left review comments

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AxelGes @codecov-commenter @wachunei @georgeweiler @metamaskbot