Skip to content

test: mocked e2e automated tests for monad and megaeth#16909

Merged
vivek-consensys merged 75 commits into
mainfrom
test-e2e-monad-megaeth
Aug 6, 2025
Merged

test: mocked e2e automated tests for monad and megaeth#16909
vivek-consensys merged 75 commits into
mainfrom
test-e2e-monad-megaeth

Conversation

@vivek-consensys

@vivek-consensys vivek-consensys commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Description

Adding e2e tests for new networks (Monad and MegaETH), which uses mocks to help minimise bugs found during the release cycle.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Comment thread e2e/resources/mock-configs.js
Comment thread e2e/resources/networks.e2e.js
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a5d5d9e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d28f1b28-e7b6-4b77-b8e3-e9191880b34b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Comment on lines +12 to +14
export const testSpecificMock = {
GET: [mockEvents.GET.suggestedGasFeesApiGanache],
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to export it again? It looks like it is strictly being used in 2 tests, could we use the one under mock-events directly?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been used in NETWORK_TEST_CONFIGS and testConfigurations

testSpecificMock: networkConfig.testSpecificMock,
},
// Remove any once withFixtures is typed
// eslint-disable-next-line @typescript-eslint/no-explicit-any

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need this any

Comment thread e2e/resources/mock-configs.js

// Transfer NFT
await TestDApp.tapNFTTransferButton();
await TestHelpers.delay(3000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded delays should be avoided.

@vivek-consensys vivek-consensys added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit d33426b Aug 6, 2025
58 of 60 checks passed
@vivek-consensys vivek-consensys deleted the test-e2e-monad-megaeth branch August 6, 2025 10:52
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-network-enablement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants