Skip to content

fix: wallet details padding for android#16899

Merged
montelaidev merged 6 commits into
mainfrom
fix/mul-316
Jul 9, 2025
Merged

fix: wallet details padding for android#16899
montelaidev merged 6 commits into
mainfrom
fix/mul-316

Conversation

@montelaidev

@montelaidev montelaidev commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes the additional padding that appears for android devices in the wallet view.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-316?atlOrigin=eyJpIjoiZGE3M2FjZmJjNTM0NDhlMDlmOTcwODY1OTk1MTE4NDMiLCJwIjoiaiJ9

Manual testing steps

  1. Enable multichain accounts design
  2. Using android
  3. Go to wallet details
  4. See that the padding a the top is aligned with the designs.

Screenshots/Recordings

Before

Screenshot_1751501864

After

Screenshot_1751501858

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev self-assigned this Jul 3, 2025
@montelaidev montelaidev requested a review from a team as a code owner July 3, 2025 00:18
@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Jul 3, 2025
@github-actions

github-actions Bot commented Jul 3, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad449a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7ebd3535-4525-4cae-bbd0-c6a3cd5978da

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@montelaidev montelaidev added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 3, 2025
@github-actions

github-actions Bot commented Jul 3, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8a8a881
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/226c6d74-8dda-4504-9533-e3ceb9c5c5cf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

owencraston
owencraston previously approved these changes Jul 4, 2025
View reviewed changes
@github-actions

github-actions Bot commented Jul 8, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7e5fa07
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d20c32e-91c7-4ea0-b7be-ea49b1747740

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f522ec7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3ac5d9b-26f1-4869-ad38-28043dc0855e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@montelaidev montelaidev enabled auto-merge July 9, 2025 09:23
@montelaidev montelaidev added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Jul 9, 2025
@montelaidev montelaidev enabled auto-merge July 9, 2025 13:41
cursor[bot]
cursor Bot reviewed Jul 9, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SafeAreaView Flex Style Missing

The SafeAreaView component lost its flex: 1 style when styles.safeArea was removed. While the Android-specific padding removal was correct, flex: 1 is still required for the component to expand and fill the available screen space, leading to layout issues.

app/components/Views/MultichainAccounts/WalletDetails/BaseWalletDetails/index.tsx#L137-L138

metamask-mobile/app/components/Views/MultichainAccounts/WalletDetails/BaseWalletDetails/index.tsx

Lines 137 to 138 in f59abde

return (
<SafeAreaView>

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ccharly
ccharly approved these changes Jul 9, 2025
View reviewed changes

@ccharly ccharly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but haven't tested it, but looking at the screenshots this seems ok)

@montelaidev montelaidev added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 6b7c060 Jul 9, 2025
43 checks passed
@montelaidev montelaidev deleted the fix/mul-316 branch July 9, 2025 14:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@ccharly ccharly ccharly approved these changes

@owencraston owencraston owencraston left review comments

Assignees

@montelaidev montelaidev

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@montelaidev @ccharly @owencraston @metamaskbot