Skip to content

chore: updates deposit region list#16887

Merged
georgeweiler merged 5 commits into
mainfrom
deposit-regions-list
Jul 9, 2025
Merged

chore: updates deposit region list#16887
georgeweiler merged 5 commits into
mainfrom
deposit-regions-list

Conversation

@georgeweiler

@georgeweiler georgeweiler commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Jul 2, 2025
@wachunei wachunei added Run Smoke E2E skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c1a699d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/85010e05-51c8-4a0b-b8ad-5f80a4b668a5

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgeweiler georgeweiler added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 9, 2025
@georgeweiler georgeweiler marked this pull request as ready for review July 9, 2025 15:55
@georgeweiler georgeweiler requested a review from a team as a code owner July 9, 2025 15:55
wachunei
wachunei previously approved these changes Jul 9, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]
cursor Bot reviewed Jul 9, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Constant and Incorrect File Extensions

The FIAT_CURRENCIES constant, previously exported from constants.ts, is missing from the new modular structure and is not re-exported from index.ts, breaking existing code. Additionally, all re-export statements in index.ts incorrectly include the .ts file extension (e.g., ./cryptoCurrencies.ts), which can cause compilation errors.

app/components/UI/Ramp/Deposit/constants/index.ts#L1-L40

metamask-mobile/app/components/UI/Ramp/Deposit/constants/index.ts

Lines 1 to 40 in 62fe26f

// Re-export all interfaces and constants from the separated files
export type {
DepositCryptoCurrency,
} from './cryptoCurrencies.ts';
export {
USDC_TOKEN,
USDT_TOKEN,
SUPPORTED_DEPOSIT_TOKENS,
} from './cryptoCurrencies.ts';
export type {
DepositPaymentMethod,
} from './paymentMethods.ts';
export {
DEBIT_CREDIT_PAYMENT_METHOD,
SEPA_PAYMENT_METHOD,
APPLE_PAY_PAYMENT_METHOD,
SUPPORTED_PAYMENT_METHODS,
} from './paymentMethods.ts';
export type {
DepositFiatCurrency,
} from './constants.ts';
export {
USD_CURRENCY,
EUR_CURRENCY,
TRANSAK_NETWORKS,
TRANSAK_SUPPORT_URL,
} from './constants.ts';
export type {
DepositRegion,
} from './regions.ts';
export {
DEPOSIT_REGIONS,
} from './regions.ts';

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
92.3% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jul 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 62fe26f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce4f3a17-4e93-4972-ad1d-e105028d9f6a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@georgeweiler georgeweiler added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 710c2c1 Jul 9, 2025
53 of 57 checks passed
@georgeweiler georgeweiler deleted the deposit-regions-list branch July 9, 2025 19:37
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@wachunei wachunei wachunei approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georgeweiler @wachunei @metamaskbot