Skip to content

Feat/oauth-clientId#16823

Merged
ieow merged 6 commits into
feat/new-srp-oauth-servicefrom
feat/oauth-clientId
Jul 1, 2025
Merged

Feat/oauth-clientId#16823
ieow merged 6 commits into
feat/new-srp-oauth-servicefrom
feat/oauth-clientId

Conversation

@ieow

@ieow ieow commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Description

As requirement to match parity with extension, the client Id need to be move out from config to env

This pr delete the client ids in the config file and add remapping of the env variable for the buildtype

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Jul 1, 2025
@ieow ieow marked this pull request as ready for review July 1, 2025 15:22
@ieow ieow merged commit 5f0d3e6 into feat/new-srp-oauth-service Jul 1, 2025
30 of 32 checks passed
@ieow ieow deleted the feat/oauth-clientId branch July 1, 2025 15:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants