Skip to content

chore: updated homepage filters#16799

Merged
brianacnguyen merged 11 commits into
mainfrom
homepage/filters
Jul 10, 2025
Merged

chore: updated homepage filters#16799
brianacnguyen merged 11 commits into
mainfrom
homepage/filters

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Jun 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updated the homepage filter style according to redesign
https://www.figma.com/design/9e6RSJCvezaLqDQ3mtE5wB/MaWaSB?node-id=2976-108994&t=oqnsl4W6lJxFrvYq-0

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5242

Manual testing steps

  1. Go to wallet

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-07-09.at.11.27.59.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen self-assigned this Jun 30, 2025
@brianacnguyen brianacnguyen requested a review from a team as a code owner June 30, 2025 15:12
@brianacnguyen brianacnguyen added No QA Needed Apply this label when your PR does not need any QA effort. team-design-system All issues relating to design system in Mobile Run Smoke E2E labels Jun 30, 2025
@github-actions

github-actions Bot commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Jun 30, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 72de0f8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/682b8dd9-9a89-44f6-be59-435e4f2bea9e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@amandaye0h

amandaye0h commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

@brianacnguyen Looks like the filter isn't picking up the design system fonts — here, it seems like the fallback font is used. Can you make sure the correct fonts apply?

@brianacnguyen

brianacnguyen commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

@brianacnguyen Looks like the filter isn't picking up the design system fonts — here, it seems like the fallback font is used. Can you make sure the correct fonts apply?

Good catch. Let me update

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 9, 2025
@amandaye0h

amandaye0h commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Looking good! TYSM 🥳

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@brianacnguyen brianacnguyen enabled auto-merge July 9, 2025 23:54
@brianacnguyen brianacnguyen added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 7c3599f Jul 10, 2025
43 checks passed
@brianacnguyen brianacnguyen deleted the homepage/filters branch July 10, 2025 01:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brianacnguyen brianacnguyen

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brianacnguyen @amandaye0h @darkwing @metamaskbot