Skip to content

chore: Update default font from CentraNo1 to Geist#16609

Merged
brianacnguyen merged 45 commits into
mainfrom
fix/typography-android
Jul 2, 2025
Merged

chore: Update default font from CentraNo1 to Geist#16609
brianacnguyen merged 45 commits into
mainfrom
fix/typography-android

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updates fonts in Metamask

  • Updated default font from Centra No 1 to Geist
  • Updated all typography files to match its font name. This is important for npx react-native-asset to properly link the fonts
  • Updated font weights to be added on android only to prevent unintended bug on ios
  • Added all fonts to QA and Flask

Related issues

Fixes: #16608

Manual testing steps

  1. Run yarn setup from root
  2. Run yarn start:android or yarn start:ios
  3. Make sure all fonts are rendered correctly (https://vercel.com/font)

Screenshots/Recordings

Before

After

Android
Screenshot_1750716043

iOS
Simulator Screenshot - iPhone 15 Pro Max - 2025-06-23 at 15 04 48

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen self-assigned this Jun 23, 2025
@brianacnguyen brianacnguyen requested a review from a team as a code owner June 23, 2025 22:32
@github-actions

github-actions Bot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Jun 23, 2025
@brianacnguyen brianacnguyen added needs-qa Any New Features that needs a full manual QA prior to being added to a release. Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking Run Smoke E2E and removed Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Jun 23, 2025
@github-actions

github-actions Bot commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 371c0b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4202a8af-b437-4d6d-b0dd-b7fbe64c225c

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@georgewrmarshall georgewrmarshall requested a review from Copilot June 23, 2025 22:36
@brianacnguyen brianacnguyen requested review from zone-live and removed request for Copilot June 23, 2025 22:36

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: ff88472df78667ccc8b5fa3df030892947d0546e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/886b3dcf-a609-4809-b801-9ab3fe4ee3b3

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen force-pushed the fix/typography-android branch from ff88472 to 371c0b1 Compare June 23, 2025 22:44
@github-actions

github-actions Bot commented Jun 23, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ead8374
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33f10788-847a-4332-adfa-04797f05643b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 58abbef
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8d7c47e-7a5b-4cc4-a95a-f31886796fc8

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

amitabh94
amitabh94 previously approved these changes Jul 1, 2025
View reviewed changes
Akatori-Design
Akatori-Design previously approved these changes Jul 1, 2025
View reviewed changes

@Akatori-Design Akatori-Design left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Jul 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0ea64cb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e80f727b-558c-4e2a-b978-e0cea58fbf34

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Jul 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b0ab716
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/386ac038-112d-4896-8909-b9758c5da4b9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

This comment was marked as outdated.

Sign in to view
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Jul 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 50f4619
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dab0205b-012c-4970-b3ac-6db305ea160a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@codecov-commenter

codecov-commenter commented Jul 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.43%. Comparing base (33b8046) to head (50f4619).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16609      +/-   ##
==========================================
+ Coverage   72.40%   72.43%   +0.02%     
==========================================
  Files        2709     2719      +10     
  Lines       58754    58963     +209     
  Branches     9254     9316      +62     
==========================================
+ Hits        42540    42708     +168     
- Misses      13517    13524       +7     
- Partials     2697     2731      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cursor[bot]

This comment was marked as outdated.

Sign in to view

zone-live
zone-live previously approved these changes Jul 2, 2025
View reviewed changes
bfullam
bfullam previously approved these changes Jul 2, 2025
View reviewed changes
cursor[bot]

This comment was marked as off-topic.

Sign in to view

@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sethkfman
sethkfman approved these changes Jul 2, 2025
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@cursor cursor[bot] cursor[bot] left review comments

@zone-live zone-live zone-live approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@bfullam bfullam bfullam approved these changes

@javiergarciavera javiergarciavera javiergarciavera approved these changes

@amitabh94 amitabh94 amitabh94 left review comments

@chrisleewilcox chrisleewilcox Awaiting requested review from chrisleewilcox

@tommasini tommasini Awaiting requested review from tommasini

+2 more reviewers

@sethkfman sethkfman sethkfman approved these changes

@Akatori-Design Akatori-Design Akatori-Design left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@brianacnguyen brianacnguyen

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.51.0 Issue or pull request that will be included in release 7.51.0 team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: update default font from CentraNo1 to Geist